Skip to content

gh-40928: Avoid swallowing AlarmInterrupt in matrix destructor #42609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cxzhong wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

gh-40928: Avoid swallowing AlarmInterrupt in matrix destructor #42609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/sage/matrix/matrix_modn_dense_flint.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ cdef class Matrix_modn_dense_flint(Matrix_dense):
sage: A = matrix(Zmod(36), 3, 3, range(9))
sage: del A
"""
sig_on()
# Destructors cannot propagate exceptions, so this must not be
# wrapped in sig_on()/sig_off().
nmod_mat_clear(self._matrix)
sig_off()

cdef void set_unsafe_int(self, Py_ssize_t i, Py_ssize_t j, int value) noexcept:
nmod_mat_set_entry(self._matrix, i, j, value)
Expand Down Expand Up @@ -903,7 +903,7 @@ cdef class Matrix_modn_dense_flint(Matrix_dense):
[9223372036854775800]
"""
cdef Py_ssize_t i, j, m = self._nrows, n = self._ncols
cdef mp_limb_t x, preN, preshift, N = modulus
cdef mp_limb_t x, preN, preshift = 0, N = modulus
preN = n_preinvert_limb(N)
if not mul:
preshift = n_preinvert_limb(shift)
Expand Down
Loading