frontend/registration tokens: improve exam mode #8683

haraldschilly · 2025-12-16T16:46:02Z

This moves some fields into an expandable row, otherwise table too wide. Some tweaks to the columns. Buttons to copy token or ephemeral URL. Add/Edit is a dialog now.

This also adds adding a license id and storing the disable internet info in the ephemeral project.

Extra: adding a client-side timeout for that client.conat_client.hub.db.userQuery call. there is a timeout flag, but it is passed on to conat, and kind of dropped. what's certainly missing is a frontend timeout.

"Custom" can be edited

…triction

haraldschilly · 2025-12-17T11:49:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/admin/registration-token-hook.tsx

haraldschilly · 2025-12-17T14:06:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/admin/registration-token-dialog.tsx

haraldschilly · 2025-12-17T18:06:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/client/query.ts

haraldschilly · 2025-12-18T10:02:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

cocalc/src/packages/server/projects/create.ts

Lines 85 to 89 in 3d511e4

    
             description, 
        
             image, 
        
           }); 
        
           if (project_id != null) { 
        
             return project_id;

Pool reuse skips disableInternet customization

When createProject can pull a project from the pool with no licenses, it returns immediately after getFromPool without applying any of the new customize settings. If a registration token sets customize.disableInternet (or other future settings) but doesn’t supply a license, this branch will reuse a pooled project and return before writing the settings JSON, so the project is created with full internet access despite the token requesting it. Consider bypassing the pool or updating the pooled project when customization is present.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/admin/registration-token-hook.tsx

haraldschilly · 2025-12-18T10:23:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/admin/registration-token.tsx

haraldschilly · 2025-12-18T10:45:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/client/query.ts

… token

haraldschilly · 2025-12-18T11:24:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/packages/frontend/admin/registration-token-dialog.tsx

haraldschilly added PR-work in progress PR-TODO-cocalc2 merge/migrate this PR into CoCalc2 in the future labels Dec 16, 2025

haraldschilly force-pushed the fix-exam-mode-20251216 branch 10 times, most recently from 486a33f to e64eb9f Compare December 17, 2025 10:59

frontend/registration tokens: refactor, fix custom time, internet res…

f8271d7

…triction

haraldschilly force-pushed the fix-exam-mode-20251216 branch 2 times, most recently from ddd2072 to 1d5b8a8 Compare December 17, 2025 11:49

chatgpt-codex-connector bot reviewed Dec 17, 2025

View reviewed changes

src/packages/frontend/admin/registration-token-hook.tsx Show resolved Hide resolved

haraldschilly force-pushed the fix-exam-mode-20251216 branch from 1d5b8a8 to 4768174 Compare December 17, 2025 13:39

chatgpt-codex-connector bot reviewed Dec 17, 2025

View reviewed changes

src/packages/frontend/admin/registration-token-dialog.tsx Outdated Show resolved Hide resolved

haraldschilly marked this pull request as ready for review December 17, 2025 14:21

registration tokens: license and disableInternet frontend->backend

42666bf

haraldschilly force-pushed the fix-exam-mode-20251216 branch 3 times, most recently from ca9b0e8 to 5d3c110 Compare December 17, 2025 16:43

frontend/registration tokens: bugfixing, details

211e25d

haraldschilly force-pushed the fix-exam-mode-20251216 branch 3 times, most recently from 17994f2 to 84a3625 Compare December 17, 2025 17:46

haraldschilly removed the PR-work in progress label Dec 17, 2025

haraldschilly added the PR-needs testing work done, only testing left to do label Dec 17, 2025

backend/quota: disable network if settings say disableInternet=true

e64e1a6

haraldschilly force-pushed the fix-exam-mode-20251216 branch from 84a3625 to e64e1a6 Compare December 17, 2025 18:05

chatgpt-codex-connector bot reviewed Dec 17, 2025

View reviewed changes

src/packages/frontend/client/query.ts Outdated Show resolved Hide resolved

haraldschilly added PR-needs review and removed PR-needs testing work done, only testing left to do labels Dec 18, 2025

chatgpt-codex-connector bot reviewed Dec 18, 2025

View reviewed changes

src/packages/frontend/admin/registration-token-hook.tsx Show resolved Hide resolved

haraldschilly force-pushed the fix-exam-mode-20251216 branch from 3d511e4 to f706a19 Compare December 18, 2025 10:23

chatgpt-codex-connector bot reviewed Dec 18, 2025

View reviewed changes

src/packages/frontend/admin/registration-token.tsx Show resolved Hide resolved

haraldschilly force-pushed the fix-exam-mode-20251216 branch from f706a19 to adde523 Compare December 18, 2025 10:45

chatgpt-codex-connector bot reviewed Dec 18, 2025

View reviewed changes

src/packages/frontend/client/query.ts Outdated Show resolved Hide resolved

haraldschilly force-pushed the fix-exam-mode-20251216 branch from adde523 to 427785c Compare December 18, 2025 11:05

frontend/client/query: refactor and only add timeout for registration…

b5b1fd8

… token

haraldschilly force-pushed the fix-exam-mode-20251216 branch from 427785c to b5b1fd8 Compare December 18, 2025 11:24

chatgpt-codex-connector bot reviewed Dec 18, 2025

View reviewed changes

src/packages/frontend/admin/registration-token-dialog.tsx Show resolved Hide resolved

haraldschilly merged commit 44ad667 into master Dec 18, 2025
4 checks passed

	description,
	image,
	});
	if (project_id != null) {
	return project_id;

frontend/registration tokens: improve exam mode #8683

frontend/registration tokens: improve exam mode #8683

Uh oh!

Conversation

haraldschilly commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haraldschilly commented Dec 17, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

haraldschilly commented Dec 17, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

haraldschilly commented Dec 17, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

haraldschilly commented Dec 18, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

haraldschilly commented Dec 18, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

haraldschilly commented Dec 18, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

haraldschilly commented Dec 18, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

haraldschilly commented Dec 16, 2025 •

edited

Loading