database: decaffeinate #8687
Open
database: decaffeinate #8687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldschilly
added
PR-work in progress
PR-TODO-cocalc2
haraldschilly
force-pushed
the
decaff-20251223
branch
from
5fc8bcc to
57f3373
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
57f3373 to
db90cff
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
c77ebf6 to
041a162
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
a0aae98 to
7fdda16
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
8 times, most recently
from
291eab8 to
b25c175
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
b25c175 to
54a9545
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
3 times, most recently
from
380fbc7 to
14bec95
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
4 times, most recently
from
4598839 to
4b79a06
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
4 times, most recently
from
6460117 to
b231d9f
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
b231d9f to
2f19659
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Resolved conflicts: - postgres-user-queries.coffee: Removed (already converted to TypeScript) - packages/database/postgres/types.ts: Merged method signatures - packages/server/projects/collaborators.ts: Integrated ownership checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
…d adjust tests -- issue appeared after merging in the diverging changes from branch project-transfer-ownership-7718
haraldschilly
force-pushed
the
decaff-20251223
branch
from
d573594 to
af07175
Compare
- drop _clients/_client_index and make pg.Pool the core connection for PostgreSQL - remove per-instance connection options and assume shared pool config - add _get_query_client/_get_listen_client and keep a dedicated LISTEN/NOTIFY client - route queries through pooled clients and update connect/disconnect semantics - adjust sync/message/group helpers to release pooled clients - remove backup/restore ops from database API while keeping getBackupTables/NON_CRITICAL_TABLES - update tests and cleanup to close listen clients and await pool shutdown
haraldschilly
force-pushed
the
decaff-20251223
branch
from
af07175 to
0629ac8
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
d46442f to
93c754d
Compare
haraldschilly
force-pushed
the
decaff-20251223
branch
from
93c754d to
8918076
Compare
- Treat array types as ARRAY when checking column diffs to avoid false alters - Keep schemaNeedsSync logging at info with clearer messages and a schema-matches line - Add unit coverage for array and double precision column comparisons - Update accounts schema banner year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
things to add
pg_try_advisory_lock