fix: use asyncio.sleep in async _retry_with_backoff #8706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_retry_with_backoff` function in `jupyter.py` was using `time.sleep`, which blocks the event loop when called from the async `jupyter_execute` function. This commit replaces the synchronous `_retry_with_backoff` with an asynchronous version that uses `asyncio.sleep` to prevent blocking the event loop. The `jupyter_execute` function has been updated to be async and use the new retry logic. I also fixed a bug where newline characters were being escaped in f-strings.
haraldschilly
added
PR-needs testing
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_retry_with_backofffunction injupyter.pywas usingtime.sleep, which blocks the event loop when called from the asyncjupyter_executefunction.This commit replaces the synchronous
_retry_with_backoffwith an asynchronous version that usesasyncio.sleepto prevent blocking the event loop. Thejupyter_executefunction has been updated to be async and use the new retry logic.I also fixed a bug where newline characters were being escaped in f-strings.