Migrated commit_represent to S3Represent

[anurag-ks]

No description provided.

[nursix]

Makes no difference with S3Represent if you call other represents per-row.

[nursix]

You should call the bulk-method of the same (!) represent instances once during lookup_rows for /all/ values.

That will store the representations in the instance, so that when you call them per-row in represent_row, they wouldn't be looked up again.

[anurag-ks]

@nursix and @flavour done

[nursix]

This constructor does basically nothing - so should be removed.

[nursix]

This is the right concept - but a sloppy implementation of it ;)

You should always test your code before submitting a PR - and this code can not work, so you either didn't test it, or you ignored that it doesn't work ;)

[anurag-ks]

Actually @nursix I did tried to test it, but I think they way I tested it is wrong, sorry for that.

[nursix]

@anurag-ks - generally no problem to ask for feedback on the concept by tagging me in a comment to your commit before submitting a PR. But for a PR, stuff should be working.

You could try to write a unit test for this (even if just as an exercise) - this would give you immediate feedback while refactoring things.

[anurag-ks]

@nursix just a doubt, these represent classes/functions are used for custom rendering of data values for data-tables or exporting data, right ? But on enabling the commit_id field on /eden/req/commit gives me None

[flavour]

for req/commit there is no 'commit_id' field, there is an 'id' field which in other places would be seen as a commit_id

[flavour]

these represent classes/functions are used for custom rendering of data values for data-tables or exporting data, right ?

yes

[anurag-ks]

Okay so commit_id is for components, but it's not there on the data tables.
To be honest I haven't written any unit tests before (only automation stuff), so I was checking out other ways to test it.

[nursix]

A unit test would create a test req_commit record, and then run req_CommitRepresent against the record ID. Then check whether the return value is correct, and finally remove the test record.

That's all there is to it, nothing fancy.

[nursix]

There are over 500 examples of unit tests in modules/unit_tests and plenty of documentation for the Python unittest module. It's not rocket science - the trick is just to understand what you're trying to prove with the test and implement a valid test.

[nursix]

And I said that with the unittest only to spare you the effort of digging for a case where it is visible, because I understood that you couldn't find one. In fact, there may not be one ;)