Bulletin Form for OCD PH#1470
Conversation
| Name of the officer who is responsible to issue the bulletin | ||
| """ | ||
|
|
||
| return self.cap.get("bulletin_officer", "Name of Officer") |
There was a problem hiding this comment.
This stuff seems too dynamic to want to put into settings...although that is about to become more accessible via WebSetup.
Until then it would be better as a DB table? (Even with WebSetup, a DB table provides better UX)
| Name of the method that is used to generate the bulletin for this deployment | ||
| """ | ||
|
|
||
| return self.cap.get("bulletin_method") |
There was a problem hiding this comment.
Seems odd to have this be configurable via settings like this?
What I would propose would be an S3Method for cap/alert/[id]/bulletin
This would still allow the template to define a custom function in config.py
| if area_row: | ||
| # Show these buttons only if there is at least one area segment | ||
| cap_bulletin_method = settings.get_cap_bulletin_method() | ||
| if cap_bulletin_method: |
There was a problem hiding this comment.
If using the S3Method & DB configuration, the cap_bulletin table could be queried & if there is an undeleted row then proceed to add the buttons
|
Sorry for the delay in reviewing this - I just found a lot of GitHub mails in my spam folder! |
|
Thanks for review @flavour . I will get back soon |
2 participants
No description provided.