fix: uptime as 0 if status is not online#103
Open
AlfieBrooks wants to merge 2 commits intosaikatharryc:masterfrom
Open
fix: uptime as 0 if status is not online#103AlfieBrooks wants to merge 2 commits intosaikatharryc:masterfrom
AlfieBrooks wants to merge 2 commits intosaikatharryc:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the pm2_uptime metric to correctly report 0 when a service is not online, addressing issue #68 where uptime was being calculated even for offline services.
- Updates uptime calculation logic to conditionally return 0 for non-online services
- Maintains existing uptime calculation for online services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #68
pm2_uptimeisn't 0 if the service is down. This PR adds logic to only output the uptime if the servicestatusis online, else return0