-
-
Notifications
You must be signed in to change notification settings - Fork 109
fix q10, make it clearer for students #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughUpdated CKAD question 10: MySQL image changed to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
facilitator/assets/exams/ckad/001/answers.md (1)
252-292: Critical: Pod image version does not match question description.The question text (line 252) specifies
mysql:9.5.0, but the pod YAML template (line 269) usesmysql:latest. This directly contradicts the PR's intent to upgrade MySQL to version 9.5.0 specifically to resolve ARM architecture compatibility. Students following this answer will not implement the fix correctly.containers: - name: mysql - image: mysql:latest + image: mysql:9.5.0 env:
🧹 Nitpick comments (1)
facilitator/assets/exams/ckad/001/scripts/validation/q10_s3_validate_pod_env_vars.sh (1)
31-35: Error message omits the newly-validated environment variable.The validation for
MYSQL_RANDOM_ROOT_PASSWORD(line 28) is checked but not reported in the error message (lines 31-35). For debugging clarity when validation fails, the error output should include all three environment variables.else echo "❌ Error: Pod '$POD_NAME' does not have the correct secret configuration" echo "DB_USER -> Secret: $DB_USER_SECRET, Key: $DB_USER_KEY" echo "DB_PASSWORD -> Secret: $DB_PASSWORD_SECRET, Key: $DB_PASSWORD_KEY" + echo "MYSQL_RANDOM_ROOT_PASSWORD -> Secret: $MYSQL_RANDOM_ROOT_PASSWORD_SECRET, Key: $MYSQL_RANDOM_ROOT_PASSWORD_KEY" exit 1 fi
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
facilitator/assets/exams/ckad/001/answers.md(2 hunks)facilitator/assets/exams/ckad/001/assessment.json(1 hunks)facilitator/assets/exams/ckad/001/scripts/validation/q10_s1_validate_secret.sh(1 hunks)facilitator/assets/exams/ckad/001/scripts/validation/q10_s3_validate_pod_env_vars.sh(2 hunks)
🔇 Additional comments (2)
facilitator/assets/exams/ckad/001/scripts/validation/q10_s1_validate_secret.sh (1)
6-8: New random field validation is correctly integrated.The addition of the
randomsecret field is properly extracted (line 6) and validated (line 8) following the same pattern as the existingusernameandpasswordfields. The error messages (lines 13-14) appropriately reflect all three expected values.facilitator/assets/exams/ckad/001/assessment.json (1)
273-301: Question definition and verification structure is well-organized.The assessment question text (line 277) correctly specifies
mysql:9.5.0and all three secret values. The verification section (lines 279-301) logically sequences the three validation steps with appropriate weightages (2, 1, 2) that prioritize secret creation and environment variable validation.However, note that this assessment definition will validate against the correct image (9.5.0) while the provided answers.md uses
mysql:latest, creating a mismatch students will encounter.
Makes Q10 in CKAD 001 clearer for students
🧾 What this PR does
It's not clear, that MYSQL needs additional ENV vars, until you start the container.
Now it should be clearer.
This fix also fixes issue #43
🧩 Type of change
🧪 How to test it
Run the updated lab CKAD 001, Question 10. The pod should start correctly and MYSQL should be up and running.
✅ Acceptance Criteria
Pod starts without errors
Docker Compose logs are available
All relevant tests pass
Documentation is updated (if needed - usually it is)
New labs pass
Answers work as expected
📎 Related Issue(s)
Closes #43
💬 Notes for Reviewers
🧠 Additional Context
📄 Attachments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.