updating type for url

[alecha]

In the README the url for making a call is a string, whereas in the code is an url.URL

[kevinburke]

Thanks! I think I would rather leave this as a string since that's the way it gets sent to the API and returned from the API. Plus who knows if Twilio decides to accept things that are not URL-looking later on. We would be ham strung by the type choice.

On Tue, Aug 8, 2017 at 06:10 Alessio Cavaleri ***@***.***> wrote: In the README the url for making a call is a string, whereas in the code is an url.URL ------------------------------ You can view, comment on, or merge this pull request online at: #16 Commit Summary - updating type for url File Changes - *M* README.md <https://github.com/saintpete/twilio-go/pull/16/files#diff-0> (3) Patch Links: - https://github.com/saintpete/twilio-go/pull/16.patch - https://github.com/saintpete/twilio-go/pull/16.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOSI4gEzpSDhiVgncDQ0Bd-XnIf8p8kks5sWF5AgaJpZM4Owtb8> .

--

…

-- Kevin Burke 925.271.7005 | kev.inburke.com

[alecha]

The problem is that if you copy/paste the example from the README the code won't compile, that's why I've fixed it 🤔

[kevinburke]

Oh... ok give me a few

On Tue, Aug 8, 2017 at 08:32 Alessio Cavaleri ***@***.***> wrote: The problem is that if you copy/paste the example from the README the code won't compile, that's why I've fixed it 🤔 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOSIz_PHDfPmCK76zbAaIjhcb9d9oP0ks5sWH98gaJpZM4Owtb8> .

--

…

-- Kevin Burke 925.271.7005 | kev.inburke.com