-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-50368 Discussions and Dropbox improve ui responsiveness #12792
base: master
Are you sure you want to change the base?
Conversation
overflow: hidden; | ||
text-overflow: ellipsis; | ||
} | ||
.text-truncate{ | ||
white-space: normal !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Sharadhi98 is it possible to avoid using !important and rely on specificity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that text-truncate is a bootstrap class. i don't think it makes sense to override Bootstrap like this. if you don't like the use of text-truncate, the use of the class should be removed/altered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment. I will go through the code and try to avoid !important.
@@ -8,6 +8,9 @@ | |||
vertical-align: middle !important; | |||
text-align:left !important; | |||
} | |||
.table td{ | |||
text-indent: 0em !important; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand this change. where is a text-indent being applied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -74,7 +74,7 @@ | |||
<h:outputText value="#{msgs.cdfm_info_required_sign}" styleClass="reqStar"/> | |||
<h:outputText value="#{msgs.cdfm_title}"/> | |||
</h:outputLabel> | |||
<h:inputText value="#{ForumTool.composeTitle}" style="width:30em;" maxlength="250" required="true" id="df_compose_title" requiredMessage="#{msgs.cdfm_invalidMessageTitleString}"> | |||
<h:inputText value="#{ForumTool.composeTitle}" style="width:100%;" maxlength="250" required="true" id="df_compose_title" requiredMessage="#{msgs.cdfm_invalidMessageTitleString}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make use of the w-100
boostrap class here please?
Fixed the screen being too wide issue in the Discussions tool and the list of Dropboxes being too wide issue in the Dropbox tool.