SAK-51161 Login skip authentication if already authenticated and forward to url #13483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
changed the title
|
I've signed the CLA! Please refer to: https://licensing.apereo.org/ |
… in url-parameter instead
sebastianriemer
force-pushed
the
SAK-51161
branch
from
37a53af to
881eb85
Compare
|
I’ve rebased the feature branch onto the latest master and cleaned up the commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unnecessary re-authentication trigger when opening a Sakai link from within Microsoft Word. It does so by directly redirecting to the referenced
urlparameter in the URL if a session and user are present at that moment.The change works as expected in my testing, but I am not deeply familiar with all the surrounding code. I’d appreciate a careful review to ensure this doesn’t introduce unintended side effects.
Please let me know if additional tests or modifications are needed!