Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-51161 Login skip authentication if already authenticated and forward to url #13483

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sebastianriemer
Copy link

This PR fixes the unnecessary re-authentication trigger when opening a Sakai link from within Microsoft Word. It does so by directly redirecting to the referenced url parameter in the URL if a session and user are present at that moment.

The change works as expected in my testing, but I am not deeply familiar with all the surrounding code. I’d appreciate a careful review to ensure this doesn’t introduce unintended side effects.

Please let me know if additional tests or modifications are needed!

@ern ern changed the title SAK-51161 SAK-51161 Login skip authentication if already authenticated and forward to url Mar 24, 2025
@ern
Copy link
Contributor

ern commented Mar 24, 2025

Hi Sebastian thank you for submitting a PR while it is reviewed, please see our contributing guidelines and submit an ICLA or CCLA. You can see this page for more info.

@ern ern marked this pull request as draft April 1, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants