SAK-51265 Sitestats Add Sakai Icons #13534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have some photos? |
|
I added it to the Jira: https://sakaiproject.atlassian.net/browse/SAK-51265. |
kunaljaykam
reviewed
Apr 3, 2025
stetsche
requested changes
Apr 3, 2025
| @@ -188,6 +202,12 @@ $fa-font-path: "./fonts"; | |||
| warning: bi-exclamation-lg, | |||
| expanded: bi-chevron-down, | |||
| collapsed: bi-chevron-right, | |||
| sitestats-widget-visits : bi-person, | |||
| sitestats-widget-lessons : bi-book, | |||
There was a problem hiding this comment.
Should we use sakai-lessonbuildertool insead?
| sitestats-widget-visits : bi-person, | ||
| sitestats-widget-lessons : bi-book, | ||
| sitestats-widget-activity : bi-bar-chart, | ||
| sitestats-widget-resources : bi-folder, |
There was a problem hiding this comment.
Could we use sakai-resources?
| sitestats-widget-activity : bi-bar-chart, | ||
| sitestats-widget-resources : bi-folder, | ||
| sitestats-report : bi-file-text, | ||
| sitestats-add : bi-plus, |
There was a problem hiding this comment.
Could we use add mapping here?
| sitestats-widget-lessons : bi-book, | ||
| sitestats-widget-activity : bi-bar-chart, | ||
| sitestats-widget-resources : bi-folder, | ||
| sitestats-report : bi-file-text, |
There was a problem hiding this comment.
Could we define it as a general purpose mapping like report : bi-file-text, also for activity and visits.
|
Nice to see more of the silk icons getting removed, thanks @i-a-m-s-k ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Silk icons with Sakai icons to maintain consistency.