SAK-51189 Samigo gb selector render respective (un)published settings #13549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
reviewed
Apr 4, 2025
ottenhoff
reviewed
Apr 9, 2025
|
|
||
| private String gradebookGroupEnabledCache = "org.sakaiproject.tool.gradebook.group.enabled"; | ||
| private String gradebookGroupInstancesCache = "org.sakaiproject.tool.gradebook.group.instances"; | ||
| private String matchingUserGradebookItemCache = "org.sakaiproject.tool.gradebook.group.user_gradebookItem"; |
Contributor
There was a problem hiding this comment.
why are you removing the cache?
Contributor
Author
There was a problem hiding this comment.
Because we didn't use it at all, was added in the multi gradebook feature
Contributor
There was a problem hiding this comment.
I think that's from another commit that got carried on, but it's already incorporated
ottenhoff
approved these changes
Apr 10, 2025
ern
changed the title
ern
changed the title
Contributor
|
@jumarub can you rebase this PR with updates from master as the build is stuck on this one |
jesusmmp
approved these changes
Apr 11, 2025
ern
pushed a commit
that referenced
this pull request
Apr 15, 2025
…#13549) Co-authored-by: Sam Ottenhoff <[email protected]> Co-authored-by: Jesús María Méndez Pérez <[email protected]> (cherry picked from commit d69403e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.