SAK-51312 Gradebook improve GbModalWindow focus management and accessibility #13554
+111
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility Refactored the GbModalWindow component to address several focus management and accessibility issues: - Replaced naive initial focus on the first input element. The modal now defaults to focusing the main content panel itself. Added `setInitialFocusComponent()` method to allow explicitly setting a specific component to receive initial focus. - Implemented robust focus trapping. Tabbing is now confined within the modal boundary (including the header/close button). The trap correctly handles looping from the last to the first element (Tab) and first to last (Shift+Tab). This uses a namespaced event listener attached to the document to reliably capture key events. - Removed the `positionAtTop` functionality and associated JavaScript, allowing the modal to use default browser/Wicket positioning logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the GbModalWindow component to address several focus management and accessibility issues:
Replaced naive initial focus on the first input element. The modal now defaults to focusing the main content panel itself. Added
setInitialFocusComponent()method to allow explicitly setting a specific component to receive initial focus.Implemented robust focus trapping. Tabbing is now confined within the modal boundary (including the header/close button). The trap correctly handles looping from the last to the first element (Tab) and first to last (Shift+Tab). This uses a namespaced event listener attached to the document to reliably capture key events.
Removed the
positionAtTopfunctionality and associated JavaScript, allowing the modal to use default browser/Wicket positioning logic.