Skip to content

SAK-51274 Portal fix keyboard nav inside portal-main-content #13562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ottenhoff merged 2 commits into from
Apr 8, 2025
+3 −3
Merged

SAK-51274 Portal fix keyboard nav inside portal-main-content #13562

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
468aba9
SAK-51274 Portal fix keyboard nav inside portal-main-content
ottenhoff Apr 7, 2025
4a0f3ce
Revert
ottenhoff Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/skins/default/src/sass/modules/tool/portal/_portal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@

.portal-main-content {
grid-area: main;
outline: none;
}

.portal-main-container {
Expand All @@ -210,7 +211,6 @@
grid-template-rows: 1fr auto;
align-content: space-between;
overflow-x: auto;
overflow-y: auto;
}

#sakai-account-panel {
Expand Down
4 changes: 2 additions & 2 deletions portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includePage.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
#else
#set( $numberTools = $pageColumn0Tools.size() )
#end
<div class="portal-main-container container-fluid pt-4 d-flex flex-column">
Copy link
Contributor Author

@ottenhoff ottenhoff Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d-flex was added in SAK-50454 Polls improve voting ui responsiveness (#12856)

<main id="$pageWrapperClass" class="portal-main-content #if( $numberTools > 1 || $homePage)Mrphs-multipleTools #end px-3" role="main">
<div class="portal-main-container container-fluid pt-4">
<main id="$pageWrapperClass" class="portal-main-content #if( $numberTools > 1 || $homePage)Mrphs-multipleTools #end px-3" role="main" tabindex="-1">
<h1 class="skip visually-hidden" tabindex="-1" id="tocontent">${rloader.sit_contentshead}</h1>

#if (${currentRole} && $roleSwitchState == false)
Expand Down
6 changes: 6 additions & 0 deletions portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includeStandardHead.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover">

<script>
const originalPreventDefault = Event.prototype.preventDefault;
Event.prototype.preventDefault = function() {
console.trace('preventDefault called for:', this);
originalPreventDefault.apply(this, arguments);
};

var portal = {
"i18n": {
"theme_switch_to_light": "$rloader.sit_theme_switch_to_light",
Expand Down
Loading