SAK-51372 gradebook add convertStringToDouble to api #13608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
changed the title
|
Why make this public? There are no calls in this PR. If this is something of use in Sakai generally, we should add it to the kernel, imo. |
Our own tools need to call convertStringToDouble, so we need adding this method on the api. |
stetsche
approved these changes
Apr 15, 2025
|
I think this should be moved into kernel utils. I would have moved it in there during my big refactor, if I would have known it was to be public. There is no code in that method that uses grading api stuff, so it shouldn't be on the grading api. Take a look at NumberUtil in kernel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-51372