SAK-51363 Forums deleting a topic that was duplicated would remove attachment used by other topics #13638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When duplicating a topic with attachments, the original implementation reused the same attachment ID, creating a shared reference to the same underlying file. This caused problems when a duplicated topic was deleted, as it would try to access attachments that no longer existed. The fix: 1. Added a new createDuplicateDFAttachment method to properly copy attachment files 2. Modified duplicateTopic to use the new method, ensuring each attachment gets a true copy 3. Uses ContentHostingService.copyAttachment to create actual copies of files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ern
approved these changes
Apr 22, 2025
|
I think this patch is not working fine... also this solution is only to topics. What about forums? |
|
idk about forums. it wasn't part of the JIRA. happy to deal with it later. what is not working fine? i tested locally and it fixed the test case. |
ern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplicating a topic with attachments, the original implementation reused the same attachment ID, creating a shared reference to the same underlying file.
This caused problems when a duplicated topic was deleted, as it would try to access attachments that no longer existed.
The fix: