SAK-51413 webapi add endpoints to retrieve assessment scheduled data #13651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
requested changes
Apr 24, 2025
|
|
||
| // Main query to retrieve site data using date range and limit/offset for pagination | ||
| // The parameters returned are SITE_ID, TITLE, CREATEDON, MODIFIEDON, and SOFTLY_DELETED_DATE | ||
| String query = "SELECT SITE_ID, TITLE, CREATEDON, MODIFIEDON, SOFTLY_DELETED_DATE " + |
There was a problem hiding this comment.
Use the site service for this.
| @Autowired | ||
| private UserDirectoryService userDirectoryService; | ||
|
|
||
| @GetMapping(value = "/assessment/scheduled", produces = MediaType.APPLICATION_JSON_VALUE) |
There was a problem hiding this comment.
If this is Samigo stuff, it should not be in the SitesController.
| conn.setReadOnly(true); | ||
|
|
||
| // Set date parameters and retrieve total elements | ||
| countPs = conn.prepareStatement(countQuery); |
There was a problem hiding this comment.
We don't need to do raw JDBC code in Sakai. We have the sqlService and Hibernate. Hibernate is the way to do it. And, generally, you should do db code in backend service and make sure to write unit tests for it.
There was a problem hiding this comment.
Completely agree putting in raw jdbc code bypasses hibernate, you should fetch this information using the service
ern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-51413