SAK-51422 Announcement Widget - Now respects close date for instructors #13662
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, instructors could see announcements after their close date in the Dashboard and Overview widgets, while students couldn't. This was confusing for instructors who would assume these announcements were visible to students. Removed the early return for users with read.draft permission, allowing the retract date check to apply to all users including instructors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
SedueRey
suggested changes
Apr 28, 2025
| @@ -562,7 +562,8 @@ public boolean isMessageViewable(Message message) { | |||
| String siteId = entityManager.newReference(message.getReference()).getContext(); | |||
|
|
|||
| if (unlockCheck(SECURE_READ_DRAFT, siteService.siteReference(siteId))) { | |||
There was a problem hiding this comment.
Human would have noticed this if is redundant and should have been deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, instructors could see announcements after their close date in the Dashboard and Overview widgets, while students couldn't. This was confusing for instructors who would assume these announcements were visible to students.
Removed the early return for users with read.draft permission, allowing the retract date check to apply to all users including instructors.
🤖 Generated with Claude Code
Zero humans have tested this code.