Skip to content

Conversation

@st-manu
Copy link
Contributor

@st-manu st-manu commented Dec 10, 2025

https://sakaiproject.atlassian.net/browse/SAK-52197

The comments.txt file should only be downloaded when selecting “Feedback comments (comments.txt file if available in student's folder. Comments are put into the Instructor Comments field for each student's submission)”. Currently, it is downloaded every time, with an exception for duplicate files if the checkbox is selected.

Summary by CodeRabbit

Release Notes

  • Updates
    • Group submission ZIP downloads will no longer include instructor comments as a separate file. Comments will need to be accessed through the assignment interface directly.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

Removed the comments.txt ZIP entry creation from group submissions in AssignmentServiceImpl. Instructor comments per group are no longer included in generated group submission ZIP files, reducing ZIP entry count and altering associated error handling paths.

Changes

Cohort / File(s) Change Summary
Group submissions ZIP entry removal
assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
Removed block that created comments.txt ZIP entry for group submissions in zipGroupSubmissions path

Possibly related PRs

Suggested reviewers

  • jesusmmp
  • ottenhoff

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the specific issue (SAK-52197) and accurately describes the main problem being fixed: group assignment downloads were only retrieving one group instead of all submissions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

This PR has been automatically marked as stale due to 21 days of inactivity. It will be closed in 7 days unless there is new activity.

@github-actions github-actions bot added the stale label Jan 1, 2026
@st-manu st-manu removed the stale label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant