SAK-52257 Global lti-util and sakai-portal-util in shared and elsewhere

[ern]

… elsewhere

https://sakaiproject.atlassian.net/browse/SAK-52257

Summary by CodeRabbit

• Chores
  • Updated Maven dependency scope configurations across the project to optimize how dependencies are resolved and managed, affecting build-time visibility and package composition.
  • Modified deployment target configuration in build settings to establish a consistent deployment strategy.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[ern]

this solves the the startup issues causing cypress tests to not run

[coderabbitai]

Caution

Review failed

The head commit changed during the review from 6ab6f1a to bf176ab.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Walkthrough

Maven dependency declarations and build properties are modified across three pom.xml files. One dependency is removed from deploy/pom.xml, two dependencies are scoped as "provided" in master/pom.xml, and a build property is activated in portal-util's configuration file.

Changes

Cohort / File(s)	Summary
Parent-level Dependency Management master/pom.xml	Added "provided" scope to org.sakaiproject.portal:sakai-portal-util and org.sakaiproject.lti:lti-util dependencies, changing their transitive availability
Parent-level Dependency Management deploy/pom.xml	Removed org.sakaiproject.portal:sakai-portal-util dependency declaration from the compiled/exported dependencies
Module Build Configuration portal/portal-util/util/pom.xml	Activated deploy.target property with value shared, replacing a previously commented-out properties block

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly aligns with the main changeset: it references moving lti-util and sakai-portal-util to shared/global locations, which matches the core changes across the three POM files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8001071 and bf176ab.

📒 Files selected for processing (3)

• deploy/pom.xml
• master/pom.xml
• portal/portal-util/util/pom.xml

💤 Files with no reviewable changes (1)

• deploy/pom.xml

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{html,jsp,vm,xhtml,xml}

📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)

**/*.{html,jsp,vm,xhtml,xml}: Use Bootstrap 5.2 as the preferred UI framework for styling in Sakai frontends
Leverage Bootstrap 5 components for consistent UI/UX

Files:

• master/pom.xml
• portal/portal-util/util/pom.xml

**/*.{html,jsp,vm,xhtml,xml,css,scss}

📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)

Ensure all UI components work across different screen sizes (Responsive Design)

Files:

• master/pom.xml
• portal/portal-util/util/pom.xml

**/*.{js,html,jsp,vm,xhtml,xml}

📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)

Use the web components in the webcomponents/ directory when possible in Sakai frontends

Files:

• master/pom.xml
• portal/portal-util/util/pom.xml

**/*.{html,jsp,jspx,xml,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Prefer kebab-case for values of HTML class and id attributes

Files:

• master/pom.xml
• portal/portal-util/util/pom.xml

🧠 Learnings (1)

📚 Learning: 2025-11-24T19:12:27.663Z

Learnt from: CR
Repo: sakaiproject/sakai PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T19:12:27.663Z
Learning: Deploy to Tomcat using `mvn clean install sakai:deploy -Dmaven.tomcat.home=/path/to/tomcat`

Applied to files:

• portal/portal-util/util/pom.xml

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: sakai-deploy
• GitHub Check: maven-build
• GitHub Check: maven-build

🔇 Additional comments (3)

master/pom.xml (2)

1686-1691: LGTM: Correct scope for shared deployment.

The provided scope for sakai-portal-util is appropriate given the artifact is now deployed to Tomcat's shared/lib directory. This prevents duplicate packaging in individual webapp WARs while ensuring the library remains available at runtime.

---

1794-1799: LGTM: Consistent scope change for shared deployment.

The provided scope for lti-util follows the same pattern as sakai-portal-util, indicating this artifact will also be globally available from Tomcat's shared/lib directory.

Verify that the lti-util module has been configured with deploy.target=shared in its pom.xml to match this scope change. The verification script in the previous comment will check this configuration.

portal/portal-util/util/pom.xml (1)

17-19: Change is correctly aligned with existing configuration.

The deploy.target=shared property in sakai-portal-util is consistent with the deployment strategy. Both sakai-portal-util and lti-util are configured with deploy.target=shared and declared with <scope>provided</scope> in master/pom.xml. Consuming modules inherit this scope from the parent POM, ensuring proper coordination without duplication.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}