SAK-52334 Global changes in FormattedText content sanitization in tools#14362
Open
ern wants to merge 2 commits intosakaiproject:masterfrom
Open
SAK-52334 Global changes in FormattedText content sanitization in tools#14362ern wants to merge 2 commits intosakaiproject:masterfrom
ern wants to merge 2 commits intosakaiproject:masterfrom
Conversation
Contributor
WalkthroughThis PR replaces StringBuilder-based alert/error collection and related try/catch/early-return logic in FormattedText processing calls across many modules by calling FormattedText.processFormattedText/processHtmlDocument with null error parameters and removing alert propagation. Changes
Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@samigo/samigo-qti/src/test/org/sakaiproject/tool/assessment/services/qti/QTIServiceTest.java`:
- Around line 61-62: The test mocks an overload of
FormattedText.processFormattedText that doesn't exist (it uses
processFormattedText(String, null, null)); update the mock in QTIServiceTest to
match the real method signature by using ArgumentMatchers.anyString() and
ArgumentMatchers.any(StringBuilder.class) (and the correct matcher for the third
param) so the Mockito.when targets the actual overload, and also fix
XmlUtil.java calls that pass nulls to call processFormattedText(value, new
StringBuilder(), ...) (or otherwise supply a non-null StringBuilder) so
production code and test use the same valid signature.
samigo/samigo-qti/src/test/org/sakaiproject/tool/assessment/services/qti/QTIServiceTest.java
Show resolved
Hide resolved
ern
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-52334
Summary by CodeRabbit
Refactor
Chores