Replace ObjectAnimator with Transitions API #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey this looks really nice, kaeawc. Just wanted to let you know that I'll review this in a couple days. I'm a bit occupied with a few things on this side. |
|
I tested the changes with my Java version of the project and didn't notice any problems. 👍 |
|
@kaeawc the transition works perfectly but there's a short moment where the cursor jumps a bit :( I tried fiddling around, but I'm short on ideas here. Do you think this can be solved?
|
|
I have some ideas for that, will experiment sometime this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you like this or would prefer something different, happy to modify. And THANK YOU for the super nice project, it was a joy to experiment with.
It seems that setting the height on the view's
LayoutParamswas what was holding up the TransitionsManager from detecting the original state of the content view, but we also don't know the bounds on the first pass - adding apost(Runnable)allows us to get the proper original height right after the first layout pass.