Azure Pipeline でのみ実装されている cppcheck を GitHub Actions に移植する#2084
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the cppcheck job from Azure Pipeline to GitHub Actions to align CI/CD services on GitHub.
- Introduces a new GitHub Actions workflow for cppcheck running on Windows with matrix configurations.
- Implements installation, execution, artifact zipping, and artifact upload steps for cppcheck.
Comments suppressed due to low confidence (2)
.github/workflows/cppcheck.yml:39
- Consider verifying that the installer path resolves correctly across environments or add a step to check for the existence of the installer before running the installation.
run: msiexec /i externals\cppcheck\cppcheck-1.84-x64-Setup.msi /quiet /qn /norestart /log cppcheck-install.log
.github/workflows/cppcheck.yml:54
- Ensure that the glob pattern '**Log.zip' precisely targets the intended log file(s) to avoid inadvertently including unrelated files in the artifacts.
path: '**Log.zip'
|
berryzplus
approved these changes
Jun 23, 2025
| - '.github/*' | ||
| - '.gitignore' | ||
| - '.editorconfig' | ||
| - 'appveyor.yml' |
Contributor
There was a problem hiding this comment.
対応不要。
pathsで拡張子（cpp、h、hpp）を指定したほうが直接的で分かりやすいかも。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci/azure-pipelines/template.job.cppcheck.yml の JOB で実装されている処理を GitHub Actions に移植
PR対象
カテゴリ
PR の背景
利用するCI/CDサービスをGitHub Actionsに一本化するために Azure Pipeline でのみ実装されている job を
GitHub Actions で実装しなおす。
仕様・動作説明
PR の影響範囲
GitHub Actions
テスト内容
CI で実行されている処理で cppcheck の artifacts が生成されること
関連 issue, PR
#1809
参考資料
cursor.sh を使って azure pipeline の job の移植の大部分を行いました。