appveyor 用の変数定義および説明を削除#2097
Merged
m-tmatma merged 6 commits intoJun 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes all AppVeyor-specific variable definitions, commands, and documentation in favor of GitHub Actions for CI.
- Removed AppVeyor-related comments and copy commands in batch scripts.
- Eliminated AppVeyor-specific test filtering and logging features.
- Updated documentation to reflect the change in CI environment.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| zipArtifacts.bat | Removed AppVeyor variable comment and file copy for AppVeyor. |
| tests/unittest.md | Deleted the reference to the AppVeyor test filtering batch file. |
| tests/test_result_filter_tell_AppVeyor.bat | Removed entire file as it is no longer needed. |
| tests/run-tests.bat | Removed AppVeyor conditional block and related logic. |
| sakura/githash.bat | Eliminated AppVeyor-specific variable setting and logging lines. |
| help/make-artifacts.bat | Removed AppVeyor variable comment from the header. |
| ci/build-envvars.md | Updated the environment variable documentation by removing AppVeyor references. |
| build-sln.bat | Removed the AppVeyor-specific logger configuration. |
Comments suppressed due to low confidence (8)
zipArtifacts.bat:131
- Ensure that the removal of the AppVeyor-specific comment is intentional and that any dependent documentation has been updated accordingly.
@rem "sakura"
tests/unittest.md:71
- Confirm that removal of the AppVeyor-related test filter reference aligns with the shift to GitHub Actions and update any related documentation if needed.
- tests\tests*.exe : 単体テストを実行する
tests/run-tests.bat:4
- Verify that the removal of the conditional block for APPVEYOR does not affect test output filtering in the new CI environment.
set TEST_LAUNCHED=0
sakura/githash.bat:13
- Ensure that downstream scripts and processes do not rely on the AppVeyor-specific variable settings that have now been removed.
call :set_git_variables
sakura/githash.bat:140
- Confirm that removing the AppVeyor logging output is fully aligned with the updated CI integration and that no references are inadvertently left.
@echo.
help/make-artifacts.bat:92
- Double-check that the removal of the AppVeyor-specific comment is consistent with the updated build process and documentation.
@rem "sakura"
|
berryzplus
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR対象
カテゴリ
PR の背景
#1809 で GitHub Actions への統合の方針があり、
appveyor を削除した。
appveyor 用の変数定義および説明を削除する
仕様・動作説明
PR の影響範囲
テスト内容
関連 issue, PR
参考資料