Skip to content

appveyor 用の変数定義および説明を削除#2097

Merged
m-tmatma merged 6 commits into
sakura-editor:masterfrom
m-tmatma:feature/remove-appveyor-vars
Jun 29, 2025
Merged

appveyor 用の変数定義および説明を削除#2097
m-tmatma merged 6 commits into
sakura-editor:masterfrom
m-tmatma:feature/remove-appveyor-vars

Conversation

@m-tmatma

Copy link
Copy Markdown
Member

PR対象

  • ビルド手順/CI

カテゴリ

  • 削除

PR の背景

#1809 で GitHub Actions への統合の方針があり、
appveyor を削除した。
appveyor 用の変数定義および説明を削除する

仕様・動作説明

PR の影響範囲

テスト内容

関連 issue, PR

参考資料

@m-tmatma m-tmatma requested a review from Copilot June 28, 2025 05:38
@m-tmatma m-tmatma self-assigned this Jun 28, 2025
@m-tmatma m-tmatma added CI appveyor など CI 関連 【ChangeLog除外】 appveyor labels Jun 28, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all AppVeyor-specific variable definitions, commands, and documentation in favor of GitHub Actions for CI.

  • Removed AppVeyor-related comments and copy commands in batch scripts.
  • Eliminated AppVeyor-specific test filtering and logging features.
  • Updated documentation to reflect the change in CI environment.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
zipArtifacts.bat Removed AppVeyor variable comment and file copy for AppVeyor.
tests/unittest.md Deleted the reference to the AppVeyor test filtering batch file.
tests/test_result_filter_tell_AppVeyor.bat Removed entire file as it is no longer needed.
tests/run-tests.bat Removed AppVeyor conditional block and related logic.
sakura/githash.bat Eliminated AppVeyor-specific variable setting and logging lines.
help/make-artifacts.bat Removed AppVeyor variable comment from the header.
ci/build-envvars.md Updated the environment variable documentation by removing AppVeyor references.
build-sln.bat Removed the AppVeyor-specific logger configuration.
Comments suppressed due to low confidence (8)

zipArtifacts.bat:131

  • Ensure that the removal of the AppVeyor-specific comment is intentional and that any dependent documentation has been updated accordingly.
@rem "sakura"

tests/unittest.md:71

  • Confirm that removal of the AppVeyor-related test filter reference aligns with the shift to GitHub Actions and update any related documentation if needed.
        - tests\tests*.exe : 単体テストを実行する

tests/run-tests.bat:4

  • Verify that the removal of the conditional block for APPVEYOR does not affect test output filtering in the new CI environment.
set TEST_LAUNCHED=0

sakura/githash.bat:13

  • Ensure that downstream scripts and processes do not rely on the AppVeyor-specific variable settings that have now been removed.
call :set_git_variables

sakura/githash.bat:140

  • Confirm that removing the AppVeyor logging output is fully aligned with the updated CI integration and that no references are inadvertently left.
		@echo.

help/make-artifacts.bat:92

  • Double-check that the removal of the AppVeyor-specific comment is consistent with the updated build process and documentation.
@rem "sakura"

@sonarqubecloud

Copy link
Copy Markdown

@m-tmatma m-tmatma merged commit 6ffc7c1 into sakura-editor:master Jun 29, 2025
15 checks passed
@m-tmatma m-tmatma deleted the feature/remove-appveyor-vars branch June 29, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appveyor CI appveyor など CI 関連 【ChangeLog除外】

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants