Skip to content

Conversation

@doiken23
Copy link

I fixed 2 bugs in _score() function of Meteor class.

  1. add .encode() and .decode() to stdiin and stdout functions, respectively.
  2. remove overlapped line

for the 2nd bug fix, please see the discussion in https://github.com/jcjohnson/densecap/blob/master/eval/meteor_bridge.py#L42-L46

@jiahuei
Copy link

jiahuei commented Jan 6, 2021

The _score() function is not used by METEOR at all, and can be safely removed.
Thus, the bugs are actually not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants