Migrate widgets chat send to the new unified Core API#1510
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
gugalo
approved these changes
Jul 1, 2026
DavDo
force-pushed
the
MOB-5376-migrate-chat-send-to-new-core-api
branch
5 times, most recently
from
5eb4d4f to
a250dbf
Compare
Core removed SendMessagePayload and reworked Chat/SecureConversations sending into per-type methods with onSuccess/onFailure callbacks. Replace the payload with a widgets-internal OutgoingMessage (Text/SingleChoice/File) and send text and each file attachment as separate messages, reconciling optimistic previews with the echoed message from the CHAT_MESSAGE stream by client message id (the file id for attachments). Send callbacks no longer arrive on the main thread, so SecureConversationsRepository marshals them back to it and ChatManager serializes all chat-state mapping on the main thread to keep the send-success and message-echo paths from processing the same message twice. Unit tests for the send flow updated and added. MOB-5376
DavDo
force-pushed
the
MOB-5376-migrate-chat-send-to-new-core-api
branch
from
a250dbf to
0366eec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-5376
What was solved?
Migrated the Widgets chat/secure-conversations send path to the new unified Core SDK send API.
SendMessagePayloadwith a Widgets-internal sealedOutgoingMessagetype (Text/SingleChoice/File, where a file's id doubles as its message id).onSuccess/onFailurelambdas instead ofRequestCallback<VisitorMessage>.CHAT_MESSAGEevent stream by message id.SecureConversations.sendMessageWithAttachmentsrequest (no per-message aggregation).SendSecureMessageUseCase(and its now-unusedchatRepository/IsQueueingOrLiveEngagementUseCasedependencies).SecureConversationsRepositorynow hops its send callbacks (and the message-sending state) back onto the main thread via the injectedSchedulers.Additional info:
Screenshots:
N/A — no UI changes.