Skip to content

Revert "Fix visitor attachment send crashes" (#1511)#1512

Merged
DavDo merged 2 commits into
developmentfrom
revert-pr-1511-attachment-send-crashes
Jul 2, 2026
Merged

Revert "Fix visitor attachment send crashes" (#1511)#1512
DavDo merged 2 commits into
developmentfrom
revert-pr-1511-attachment-send-crashes

Conversation

@DavDo

@DavDo DavDo commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Jira issue:
https://glia.atlassian.net/browse/MOB-xxx

What was solved?

Reverts PR #1511 ("Fix visitor attachment send crashes") on development. The two commits introduced by that PR are reverted here:

  • Revert "Guard chat item lookup when marking attachment send state" (ee9ec47f)
  • Revert "Give LocalAttachment a stable unique id" (b4c23afb)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

@DavDo DavDo requested a review from a team as a code owner July 1, 2026 11:17
@snyk-io

snyk-io Bot commented Jul 1, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@DavDo DavDo requested a review from gugalo July 1, 2026 11:17
@DavDo DavDo merged commit da75325 into development Jul 2, 2026
8 checks passed
@DavDo DavDo deleted the revert-pr-1511-attachment-send-crashes branch July 2, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants