Read version from properties file in increment-version workflow#1516
Open
DavDo wants to merge 1 commit into
Open
Read version from properties file in increment-version workflow#1516DavDo wants to merge 1 commit into
DavDo wants to merge 1 commit into
Conversation
The Bitrise Gradle Mirrors init script pollutes stdout of every Gradle invocation, so `./gradlew -q printCurrentVersionName` returned the mirror log lines along with the version, producing an invalid branch name in the Create PR step. Read widgets.versionName directly from version.properties instead, making the step immune to Gradle stdout noise.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-5436
What was solved?
The "Increment project version" Bitrise workflow (
_increment_project_version) was failing: the Bitrise Gradle Mirrors init script (bitrise-build-cache CLI) pollutes stdout of every Gradle invocation, so./gradlew -q printCurrentVersionNamereturned the mirror log lines along with the version. This produced an invalid branch name in the Create PR step and failed the build withfatal: 'project-version-increment/[Bitrise' is not a valid branch name.Now the version is read directly from
version.properties— the same file the workflow updates and commits — making the step immune to any Gradle stdout noise. Same fix as salemove/android-sdk#1073.Additional info:
version.propertiesScreenshots:
N/A