Skip to content

Add missing AsyncWebhookEventType values#454

Merged
kzuraw merged 3 commits intomainfrom
eng-905-missing-enum-values
Oct 16, 2025
Merged

Add missing AsyncWebhookEventType values#454
kzuraw merged 3 commits intomainfrom
eng-905-missing-enum-values

Conversation

@kzuraw
Copy link
Copy Markdown
Contributor

@kzuraw kzuraw commented Oct 16, 2025

Summary

Updates AsyncWebhookEventType to include all 23 missing webhook event types from the official Saleor GraphQL schema.

Changes

Added missing webhook event types:

  • Account events: Email changes, password requests, account confirmation/deletion
  • Channel events: Metadata updates
  • Gift card events: Export completion
  • Promotion events: Full promotion lifecycle (create, update, delete, start, end, rules)
  • Product & Checkout events: Product export completion, checkout full authorization
  • Staff, Voucher & Shop events: Staff password requests, voucher code management, shop metadata updates

Test plan

  • TypeScript compilation passes
  • All existing tests pass (322 tests)
  • Type definition matches official Saleor GraphQL schema
  • Manual verification: Apps can now subscribe to all available async webhook events

Reference

🤖 Generated with Claude Code

Added 23 missing webhook event types including account management events
(email changes, password requests), promotion events, export completion
events, and metadata update events.

This update ensures full compatibility with the latest Saleor GraphQL
schema for async webhook event types.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 8ca5f26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (27d2df7) to head (8ca5f26).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files         114      114           
  Lines        3754     3754           
  Branches      637      637           
=======================================
  Hits         3185     3185           
  Misses        557      557           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20251016113313.

Install it with:

pnpm add @saleor/app-sdk@0.0.0-pr-20251016113313

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds missing AsyncWebhookEventType string literals to align with the latest Saleor GraphQL schema and updates the reference link and changeset entry.

  • Extend AsyncWebhookEventType with 23 additional event types from the Saleor schema
  • Update @see docs link to the non-versioned API reference
  • Add a changeset describing the new events

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/types.ts Extends AsyncWebhookEventType with new event strings and updates the @see link to docs
.changeset/update-async-webhook-types.md Documents the added event types for release notes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/types.ts
Comment thread src/types.ts
Comment thread .changeset/update-async-webhook-types.md Outdated
…set formatting

- Re-added TRANSACTION_ACTION_REQUEST (was accidentally removed)
- Fixed changeset markdown formatting (removed extraneous "11" line)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@kzuraw kzuraw marked this pull request as ready for review October 16, 2025 11:42
@kzuraw kzuraw merged commit 6eb106f into main Oct 16, 2025
8 checks passed
@kzuraw kzuraw deleted the eng-905-missing-enum-values branch October 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants