Skip to content

Fix devcontainer setup for local Saleor development#2064

Draft
witoszekdev wants to merge 2 commits intomainfrom
fix-devcontainer-setup
Draft

Fix devcontainer setup for local Saleor development#2064
witoszekdev wants to merge 2 commits intomainfrom
fix-devcontainer-setup

Conversation

@witoszekdev
Copy link
Copy Markdown
Member

@witoszekdev witoszekdev commented Aug 14, 2025

This PR fixes devcontainer setup to allow working with local Saleor instance by making localhost resolve to host machine IP address (this is done by docker when building image, it adds a line to /etc/hosts).

It also changes local DynamoDB to run at random port instead of 8000, which is default Saleor Core port.

@witoszekdev witoszekdev requested a review from a team as a code owner August 14, 2025 17:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 14, 2025

⚠️ No Changeset found

Latest commit: 5b4cb85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
saleor-app-avatax Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-cms Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-klaviyo Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-payment-np-atobarai Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-payment-stripe Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-products-feed Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-search Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-segment Ready Preview Comment Aug 14, 2025 5:21pm
saleor-app-smtp Ready Preview Comment Aug 14, 2025 5:21pm

@witoszekdev witoszekdev added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Aug 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.16%. Comparing base (46a8cb6) to head (5b4cb85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2064   +/-   ##
=======================================
  Coverage   34.16%   34.16%           
=======================================
  Files         915      915           
  Lines       58824    58824           
  Branches     2737     2738    +1     
=======================================
  Hits        20099    20099           
  Misses      38356    38356           
  Partials      369      369           
Flag Coverage Δ
avatax 56.20% <ø> (ø)
cms 15.83% <ø> (ø)
domain 100.00% <ø> (ø)
errors 91.66% <ø> (ø)
logger 28.81% <ø> (ø)
np-atobarai 71.75% <ø> (ø)
products-feed 3.87% <ø> (ø)
search 21.52% <ø> (ø)
segment 30.61% <ø> (ø)
shared 32.46% <ø> (ø)
smtp 28.96% <ø> (ø)
stripe 70.29% <ø> (ø)
webhook-utils 11.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

image: "amazon/dynamodb-local:latest"
ports:
- 8000:8000
- "8000"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change that I think we should also change scripts to setup dynamodb - currently they are requiring localhost:8000 - maybe we should globally change that to e.g 6667 or something similar?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm good idea, I'll use a single port, so that it doesn't conflict with Saleor + works with our scripts

@witoszekdev witoszekdev marked this pull request as draft December 3, 2025 12:33
@witoszekdev
Copy link
Copy Markdown
Member Author

don't have much time to do this properly like Krzysiek requested, so will keep this as draft until then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App: AvaTax skip changeset Attach this label to PRs which does not need changes description for the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants