Fix devcontainer setup for local Saleor development#2064
Fix devcontainer setup for local Saleor development#2064witoszekdev wants to merge 2 commits intomainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
=======================================
Coverage 34.16% 34.16%
=======================================
Files 915 915
Lines 58824 58824
Branches 2737 2738 +1
=======================================
Hits 20099 20099
Misses 38356 38356
Partials 369 369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| image: "amazon/dynamodb-local:latest" | ||
| ports: | ||
| - 8000:8000 | ||
| - "8000" |
There was a problem hiding this comment.
If we change that I think we should also change scripts to setup dynamodb - currently they are requiring localhost:8000 - maybe we should globally change that to e.g 6667 or something similar?
There was a problem hiding this comment.
Hmm good idea, I'll use a single port, so that it doesn't conflict with Saleor + works with our scripts
|
don't have much time to do this properly like Krzysiek requested, so will keep this as draft until then ;) |
This PR fixes devcontainer setup to allow working with local Saleor instance by making
localhostresolve to host machine IP address (this is done by docker when building image, it adds a line to/etc/hosts).It also changes local DynamoDB to run at random port instead of
8000, which is default Saleor Core port.