Skip to content

Improve pnpm security #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkostrowski merged 7 commits into from
Apr 2, 2026
Merged

Improve pnpm security #2314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e7a577
update minimum release age to 21 days
witoszekdev Apr 1, 2026
8360d2e
pin all dependencies
witoszekdev Apr 1, 2026
0321a10
add settings for exact versions
witoszekdev Apr 1, 2026
0544b93
fix install error
witoszekdev Apr 1, 2026
e2e99ef
add frozen lockfile everywhere
witoszekdev Apr 1, 2026
5b0c145
update readme
witoszekdev Apr 1, 2026
4efec1c
Apply suggestion from @NyanKiyoshi
lkostrowski Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
save-exact=true
manage-package-manager-versions=true

# Here in npmrc, because this flag looks like not working in pnpm-workspace
# 86400 (minutes) is 60 days
# Set, because old packages in npm do not have trust policy
# Once time passes and packages are newer, we should remove this flag
trust-policy-ignore-after=86400
frozen-lockfile=true
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,15 @@ pnpm dlx turbo login
pnpm dlx turbo link
```

### Installing new packages

This has following requirements for improved supply chain security:
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar: "This has following requirements" is missing an article (e.g., "This has the following requirements") and reads a bit awkward in the README section.

Suggested change
This has following requirements for improved supply chain security:
This has the following requirements for improved supply chain security:

Copilot uses AI. Check for mistakes.

- Packages must be older than 21 days
- Added packages must use exact version (no `^` or `~`)
- Packages versions cannot have a downgraded provenance security
- All installs are using froze lockfile to prevent unintended changes in transitive dependencies, to update packages anyway, you must use: `pnpm install --no-frozen-lockfile`
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "froze lockfile" should be "frozen lockfile".

Suggested change
- All installs are using froze lockfile to prevent unintended changes in transitive dependencies, to update packages anyway, you must use: `pnpm install --no-frozen-lockfile`
- All installs are using frozen lockfile to prevent unintended changes in transitive dependencies, to update packages anyway, you must use: `pnpm install --no-frozen-lockfile`

Copilot uses AI. Check for mistakes.

## ADR

This repository uses [architecture decision records](https://cognitect.com/blog/2011/11/15/documenting-architecture-decisions) to document architectural decisions. You can find them in the `adr` directory.
Expand Down
8 changes: 4 additions & 4 deletions apps/avatax/bruno/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
"name": "bruno",
"version": "1.0.0",
"description": "",
"keywords": [],
"license": "(BSD-3-Clause AND CC-BY-4.0)",
"author": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"dependencies": {
"@faker-js/faker": "^8.4.1"
"@faker-js/faker": "8.4.1"
}
}
12 changes: 6 additions & 6 deletions apps/avatax/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@
"@trpc/react-query": "catalog:",
"@trpc/server": "catalog:",
"@vercel/otel": "catalog:",
"avatax": "^23.7.0",
"avatax": "23.7.0",
"decimal.js-light": "catalog:",
"dotenv": "catalog:",
"dynamodb-toolbox": "catalog:",
"graphql": "catalog:",
"graphql-tag": "catalog:",
"jotai": "^2.4.2",
"jotai": "2.4.2",
"jsdom": "catalog:",
"modern-errors": "catalog:",
"modern-errors-serialize": "catalog:",
Expand All @@ -75,9 +75,9 @@
"zod": "catalog:"
},
"devDependencies": {
"@faker-js/faker": "^8.4.1",
"@faker-js/faker": "8.4.1",
"@graphql-codegen/cli": "catalog:",
"@graphql-codegen/import-types-preset": "^3.0.0",
"@graphql-codegen/import-types-preset": "3.0.0",
"@graphql-codegen/introspection": "catalog:",
"@graphql-codegen/schema-ast": "4.0.2",
"@graphql-codegen/typed-document-node": "catalog:",
Expand All @@ -101,8 +101,8 @@
"eslint-plugin-n": "catalog:",
"graphql-codegen-typescript-operation-types": "catalog:",
"graphql-config": "5.0.3",
"pactum": "^3.6.0",
"pactum-matchers": "^1.1.6",
"pactum": "3.6.0",
"pactum-matchers": "1.1.6",
"tsx": "catalog:",
"typescript": "catalog:",
"vite": "catalog:",
Expand Down
2 changes: 1 addition & 1 deletion apps/cms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"@graphql-typed-document-node/core": "catalog:",
"@saleor/eslint-config-apps": "workspace:*",
"@saleor/typescript-config-apps": "workspace:*",
"@types/qs": "^6.9.7",
"@types/qs": "6.9.7",
"@types/react": "18.2.5",
"@types/react-dom": "18.2.5",
"@vitest/coverage-v8": "catalog:",
Expand Down
12 changes: 6 additions & 6 deletions apps/klaviyo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
"graphql": "catalog:",
"graphql-tag": "catalog:",
"next": "catalog:",
"node-fetch": "^3.2.6",
"node-fetch": "3.2.6",
"react": "catalog:",
"react-dom": "catalog:",
"react-helmet": "^6.1.0",
"react-helmet": "6.1.0",
"urql": "catalog:",
"usehooks-ts": "catalog:",
"vite": "catalog:",
Expand All @@ -63,15 +63,15 @@
"@types/node": "catalog:",
"@types/react": "18.2.5",
"@types/react-dom": "18.2.5",
"autoprefixer": "^10.4.7",
"clean-publish": "^4.0.1",
"autoprefixer": "10.4.7",
"clean-publish": "4.0.1",
"eslint": "catalog:",
"eslint-plugin-n": "catalog:",
"graphql-codegen-typescript-operation-types": "catalog:",
"graphql-config": "5.0.3",
"jsdom": "catalog:",
"postcss": "^8.4.14",
"pretty-quick": "^3.1.3",
"postcss": "8.4.14",
"pretty-quick": "3.1.3",
"tsx": "catalog:",
"typescript": "5.8.2"
}
Expand Down
8 changes: 4 additions & 4 deletions apps/products-feed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"dependencies": {
"@aws-sdk/client-dynamodb": "catalog:",
"@aws-sdk/client-s3": "^3.332.0",
"@aws-sdk/client-s3": "3.332.0",
"@aws-sdk/lib-dynamodb": "catalog:",
"@aws-sdk/s3-request-presigner": "3.332.0",
"@aws-sdk/util-dynamodb": "catalog:",
Expand Down Expand Up @@ -51,10 +51,10 @@
"@vitejs/plugin-react": "catalog:",
"dotenv": "catalog:",
"dynamodb-toolbox": "catalog:",
"fast-xml-parser": "^4.0.15",
"fast-xml-parser": "4.0.15",
"graphql": "catalog:",
"graphql-tag": "catalog:",
"handlebars": "^4.7.9",
"handlebars": "4.7.9",
"handlebars-helpers": "0.10.0",
"jsdom": "catalog:",
"neverthrow": "catalog:",
Expand All @@ -81,7 +81,7 @@
"@saleor/typescript-config-apps": "workspace:*",
"@testing-library/dom": "10.4.0",
"@testing-library/react": "16.2.0",
"@types/handlebars-helpers": "^0.5.6",
"@types/handlebars-helpers": "0.5.6",
"@types/react": "18.2.5",
"@types/react-dom": "18.2.5",
"@vitest/coverage-v8": "catalog:",
Expand Down
6 changes: 3 additions & 3 deletions apps/search/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@
"@trpc/server": "catalog:",
"@vercel/otel": "catalog:",
"algoliasearch": "4.23.3",
"clsx": "^1.2.1",
"debug": "^4.3.4",
"clsx": "1.2.1",
"debug": "4.3.4",
"dotenv": "catalog:",
"dynamodb-toolbox": "catalog:",
"graphql": "catalog:",
"graphql-tag": "catalog:",
"next": "catalog:",
"react": "catalog:",
"react-dom": "catalog:",
"react-helmet": "^6.1.0",
"react-helmet": "6.1.0",
"react-hook-form": "catalog:",
"urql": "catalog:",
"zod": "catalog:"
Expand Down
14 changes: 7 additions & 7 deletions apps/smtp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@aws-sdk/lib-dynamodb": "catalog:",
"@aws-sdk/util-dynamodb": "catalog:",
"@hookform/resolvers": "catalog:",
"@monaco-editor/react": "^4.4.6",
"@monaco-editor/react": "4.4.6",
"@opentelemetry/api": "catalog:",
"@opentelemetry/api-logs": "catalog:",
"@opentelemetry/instrumentation": "catalog:",
Expand Down Expand Up @@ -57,16 +57,16 @@
"dynamodb-toolbox": "catalog:",
"graphql": "catalog:",
"graphql-tag": "catalog:",
"handlebars": "^4.7.9",
"handlebars": "4.7.9",
"handlebars-helpers": "0.10.0",
"html-to-text": "^9.0.3",
"html-to-text": "9.0.3",
"jsdom": "catalog:",
"mjml": "4.15.3",
"modern-errors": "catalog:",
"modern-errors-serialize": "catalog:",
"neverthrow": "catalog:",
"next": "catalog:",
"nodemailer": "^6.9.1",
"nodemailer": "6.9.1",
"react": "catalog:",
"react-dom": "catalog:",
"react-hook-form": "catalog:",
Expand All @@ -87,10 +87,10 @@
"@graphql-typed-document-node/core": "catalog:",
"@saleor/eslint-config-apps": "workspace:*",
"@saleor/typescript-config-apps": "workspace:*",
"@types/handlebars-helpers": "^0.5.6",
"@types/html-to-text": "^9.0.0",
"@types/handlebars-helpers": "0.5.6",
"@types/html-to-text": "9.0.0",
"@types/mjml": "4.7.4",
"@types/nodemailer": "^6.4.7",
"@types/nodemailer": "6.4.7",
"@types/react": "18.2.5",
"@types/react-dom": "18.2.5",
"@vitest/coverage-v8": "catalog:",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}
},
"devDependencies": {
"@changesets/cli": "^2.30.0",
"@changesets/cli": "2.30.0",
"@cspell/cspell-types": "8.17.5",
"@saleor/app-sdk": "catalog:",
"cspell": "8.17.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/handlebars/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
"devDependencies": {
"@saleor/eslint-config-apps": "workspace:*",
"@saleor/typescript-config-apps": "workspace:*",
"@types/handlebars-helpers": "^0.5.6",
"@types/handlebars-helpers": "0.5.6",
"@vitest/coverage-v8": "catalog:",
"eslint": "catalog:",
"handlebars": "^4.7.9",
"handlebars": "4.7.9",
"handlebars-helpers": "0.10.0",
"typescript": "catalog:",
"vite": "catalog:",
Expand Down
Loading
Loading