Add local frontend validation of app manifest fields#5997
Merged
lkostrowski merged 17 commits intomainfrom Oct 24, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 5b708a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lkostrowski
added
the
skip changeset
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements local validation for app extension manifests using Zod schemas. The validation covers extension configurations, mount points, targets, and ensures proper relationships between URLs, targets, and permissions before submitting to Saleor's backend validation.
Key Changes
- Added
ExtensionManifestValidatorclass to validate app manifests with Zod schemas - Implemented comprehensive schema definitions for app manifests, extensions, targets, options, and mount points
- Added validation rules for URL patterns, permission subsets, and target-specific configurations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/extension-manifest-validator.ts | Core validator class that parses and validates app manifests |
| src/extensions/domain/app-manifest.ts | Schema for app manifest with validation for relative URLs and permission inheritance |
| src/extensions/domain/app-extension-manifest.ts | Schema for individual extensions with target/mount/URL validation rules |
| src/extensions/domain/app-extension-manifest-target.ts | Enum schema defining valid extension targets |
| src/extensions/domain/app-extension-manifest-options.ts | Schema for target-specific options with mutual exclusivity validation |
| src/extensions/domain/app-extension-manifest-available-mounts.ts | Constants defining valid mount points and widget-compatible mounts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5997 +/- ##
==========================================
+ Coverage 39.52% 39.63% +0.11%
==========================================
Files 2428 2434 +6
Lines 39532 39613 +81
Branches 8721 9058 +337
==========================================
+ Hits 15624 15701 +77
+ Misses 23882 22713 -1169
- Partials 26 1199 +1173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Differences Found✅ No packages or licenses were added. SummaryExpand
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 21 changed files in this pull request and generated 13 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lkostrowski
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 22 out of 24 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kzuraw
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added client-side validation of app manifest fields during the installation flow. This provides early feedback to users while making the installation process more permissive - converting some API-level validation errors into warnings that don't block installation.
Changes
Benefits
Next steps