Skip to content

Update dependency cruiser#6530

Merged
lkostrowski merged 3 commits intomainfrom
dep-cruiser-update
Apr 22, 2026
Merged

Update dependency cruiser#6530
lkostrowski merged 3 commits intomainfrom
dep-cruiser-update

Conversation

@lkostrowski
Copy link
Copy Markdown
Member

dependency cruiser package was very old and pnpm audit reported several vulnerabilities in it's packages

This PR updates it

Copilot AI review requested due to automatic review settings April 20, 2026 08:17
@lkostrowski lkostrowski requested a review from a team as a code owner April 20, 2026 08:17
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

⚠️ No Changeset found

Latest commit: 3f62f78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Differences Found

⚠️ 1 packages or licenses were added.

Expand
License	Package
MIT	global-directory

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC0-1.0 1
Packages
  • type-fest
MIT/X11 1
Packages
  • nub
MPL-1.1 1
Packages
  • harmony-reflect
MPL-2.0 1
Packages
  • dompurify
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
WTFPL 1
Packages
  • utf8-byte-length
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
SEE LICENSE IN LICENSE 2
Packages
  • posthog-js
  • spawndamnit
BlueOak-1.0.0 5
Packages
  • glob
  • lru-cache
  • minimatch
  • minipass
  • path-scurry
<<missing>> 11
Packages
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-arm64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • busboy
  • streamsearch
BSD-2-Clause 22
Packages
  • browser-process-hrtime
  • css-select
  • css-what
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • nth-check
  • regjsparser
  • stringify-object
  • terser
  • And 2 more...
ISC 49
Packages
  • @istanbuljs/load-nyc-config
  • anymatch
  • boolbase
  • cli-width
  • cliui
  • electron-to-chromium
  • fastq
  • flatted
  • fs.realpath
  • get-caller-file
  • get-own-enumerable-property-symbols
  • glob
  • glob-parent
  • graceful-fs
  • inflight
  • inherits
  • ini
  • isexe
  • knip
  • lru-cache
  • And 29 more...
BSD-3-Clause 52
Packages
  • @protobufjs/aspromise
  • @protobufjs/base64
  • @protobufjs/codegen
  • @protobufjs/eventemitter
  • @protobufjs/fetch
  • @protobufjs/float
  • @protobufjs/inquire
  • @protobufjs/path
  • @protobufjs/pool
  • @protobufjs/utf8
  • @saleor/app-sdk
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • @sinonjs/commons
  • And 32 more...
Apache-2.0 65
Packages
  • @editorjs/editorjs
  • @eslint/config-array
  • @eslint/config-helpers
  • @eslint/core
  • @eslint/object-schema
  • @eslint/plugin-kit
  • @humanfs/core
  • @humanfs/node
  • @humanwhocodes/module-importer
  • @humanwhocodes/retry
  • @opentelemetry/api
  • @opentelemetry/api-logs
  • @opentelemetry/core
  • @opentelemetry/exporter-logs-otlp-http
  • @opentelemetry/otlp-exporter-base
  • @opentelemetry/otlp-transformer
  • @opentelemetry/resources
  • @opentelemetry/sdk-logs
  • @opentelemetry/sdk-metrics
  • @opentelemetry/sdk-trace-base
  • And 45 more...
MIT 1340
Packages
  • @adobe/css-tools
  • @apollo/client
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-globals
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • @babel/helper-skip-transparent-expression-wrappers
  • @babel/helper-string-parser
  • And 1320 more...

Comment thread .dependency-cruiser.mjs
@@ -1,5 +1,5 @@
/** @type {import('dependency-cruiser').IConfiguration} */
module.exports = {
export default {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed legacy module syntax. This also require extension to be mjs

Comment thread pnpm-workspace.yaml
Comment on lines +12 to +14
trustPolicyExclude:
# Semver packages are not signed before 7.x. Check pnpm-lock which package is still using 6.x and plan upgrade entire tree.
- "semver@6.3.1"
Copy link
Copy Markdown
Member Author

@lkostrowski lkostrowski Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be added to ignored policies, because semver introduced signing after 7.x

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.93%. Comparing base (5b4f23d) to head (3f62f78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6530   +/-   ##
=======================================
  Coverage   47.93%   47.93%           
=======================================
  Files        2579     2579           
  Lines       45752    45752           
  Branches    10774    10808   +34     
=======================================
  Hits        21932    21932           
  Misses      22571    22571           
  Partials     1249     1249           
Flag Coverage Δ
storybook 43.04% <ø> (ø)
units 43.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s dependency-cruiser tooling to a newer version to address reported vulnerabilities and keep the dependency-check workflow current.

Changes:

  • Bump dependency-cruiser from ^12.12.2 to 17.3.10 (and refresh lockfile accordingly).
  • Update dep-status script and GitHub workflow to use a .dependency-cruiser.mjs config.
  • Add a pnpm trust-policy exclusion for semver@6.3.1.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Adds trustPolicyExclude entry for semver@6.3.1.
pnpm-lock.yaml Lockfile updates reflecting dependency-cruiser@17.3.10 and transitive upgrades.
package.json Updates dep-status to point to .dependency-cruiser.mjs and bumps dependency-cruiser version.
.github/workflows/dependency-check.yaml Switches depcruise invocations to .dependency-cruiser.mjs.
.dependency-cruiser.js Removes the previous dependency-cruiser configuration file.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread pnpm-workspace.yaml
Comment thread .github/workflows/dependency-check.yaml
Comment thread package.json
Comment thread .github/workflows/dependency-check.yaml
@lkostrowski lkostrowski enabled auto-merge (squash) April 22, 2026 09:46
@lkostrowski lkostrowski disabled auto-merge April 22, 2026 10:06
@lkostrowski lkostrowski merged commit 26ee43c into main Apr 22, 2026
22 of 23 checks passed
@lkostrowski lkostrowski deleted the dep-cruiser-update branch April 22, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants