Feature: Homepage overhaul with widgets#6551
Open
lkostrowski wants to merge 21 commits intomainfrom
Open
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6551 +/- ##
==========================================
+ Coverage 48.67% 48.79% +0.11%
==========================================
Files 2591 2604 +13
Lines 46178 46375 +197
Branches 10624 10668 +44
==========================================
+ Hits 22476 22627 +151
- Misses 23321 23367 +46
Partials 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aleor-dashboard into lkostrowski/home-app-extensions
lkostrowski
changed the title
lkostrowski
added
the
skip changeset
Comment on lines
+47
to
+58
| <Box | ||
| __width={extension.isSaleorOfficial ? 20 : 0} | ||
| __height={20} | ||
| display="inline-flex" | ||
| alignItems="center" | ||
| justifyContent="center" | ||
| data-test-id={ | ||
| extension.isSaleorOfficial ? `saleor-app-badge-${extension.id}` : undefined | ||
| } | ||
| > | ||
| {extension.isSaleorOfficial && <SaleorLogo />} | ||
| </Box> |
| size={2} | ||
| color="default2" | ||
| href={appPageUrl} | ||
| onClick={e => { |
Comment on lines
+19
to
+21
| export const useHomeRouteParams = () => { | ||
| const { extensionId: rawExtensionId } = useParams<{ extensionId?: string }>(); | ||
| const extensionId = rawExtensionId ? decodeURIComponent(rawExtensionId) : undefined; |
| as="iframe" | ||
| borderWidth={0} | ||
| __height={height as number | string} | ||
| sandbox="allow-same-origin allow-forms allow-scripts allow-downloads" |
Comment on lines
191
to
+196
| <Suspense fallback={<LoginLoading />}> | ||
| <Switch> | ||
| {legacyRedirects} | ||
| <SectionRoute exact path="/" component={WelcomePage} /> | ||
| <SectionRoute exact path="/home/widget/:extensionId" component={HomePage} /> | ||
| <SectionRoute exact path="/home/widgets" component={HomePage} /> |
lkostrowski
added
the
test deployment
…aleor-dashboard into lkostrowski/home-app-extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new Home Page. It's not yet replacing the old one - it's hidden and accessible via URL and will be available later with proper router redirect.
The new page is basically an apps' mount point area.
New mount point with optional
fullscrenn: booleanprop will render app extensions:This is part of the wider context:
Delivery flow
Screens