Skip to content

fix(build): missing job dependency & env var#6553

Merged
magul merged 1 commit intomainfrom
fix/build/missing-job-dependency
May 6, 2026
Merged

fix(build): missing job dependency & env var#6553
magul merged 1 commit intomainfrom
fix/build/missing-job-dependency

Conversation

@NyanKiyoshi
Copy link
Copy Markdown
Member

Fixes missing needs and missing env var in deployment workflow

Sample failing run: https://github.com/saleor/saleor-dashboard/actions/runs/25051037729/job/73378591096

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Fixes missing `needs` and missing env var in deployment workflow
@NyanKiyoshi NyanKiyoshi self-assigned this May 6, 2026
@NyanKiyoshi NyanKiyoshi requested a review from a team May 6, 2026 07:27
@NyanKiyoshi NyanKiyoshi added bug Something isn't working skip changeset Use if your changes doesn't need entry in changelog labels May 6, 2026
@NyanKiyoshi NyanKiyoshi requested a review from magul May 6, 2026 07:27
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: 84e1931

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.63%. Comparing base (029f589) to head (84e1931).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6553    +/-   ##
========================================
  Coverage   48.63%   48.63%            
========================================
  Files        2591     2591            
  Lines       46143    46143            
  Branches    10907    10598   -309     
========================================
  Hits        22441    22441            
- Misses      22466    23322   +856     
+ Partials     1236      380   -856     
Flag Coverage Δ
storybook 43.85% <ø> (ø)
units 44.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@magul magul merged commit 3dd76e2 into main May 6, 2026
30 of 37 checks passed
@magul magul deleted the fix/build/missing-job-dependency branch May 6, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants