-
Notifications
You must be signed in to change notification settings - Fork 165
chore: add public stock cap use-case #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peelar
wants to merge
3
commits into
main
Choose a base branch
from
chore/add-public-stock-cap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,7 +148,11 @@ the [`updateWarehouse`](api-reference/products/mutations/update-warehouse.mdx) m | |
There is an option to change the following warehouse fields: `name`, `slug`, `email`, `address` and | ||
also define privacy and `click and collect` options. | ||
|
||
We can define warehouse as public or private. Public warehouse allows you to query the stock information publicly in the API. Private warehouse requires permission. | ||
#### Public vs. private warehouses | ||
|
||
We can define warehouse as public or private. Public warehouse allows you to query the stock information publicly in the API. Private warehouse requires permission. The [`quantityAvailable`](api-reference/products/objects/product-variant.mdx#productvariantquantityavailableint--) field on `ProductVariant` type is the sum of the available quantity in all public and private warehouses. | ||
|
||
Storefronts can display product availability at specific locations with public stock. To protect business-sensitive details, you can cap public stock at the maximum orderable quantity per checkout: [`quantityLimitPerCustomer`](api-reference/products/inputs/product-variant-input.mdx#productvariantinputquantitylimitpercustomerint--). Therefore, if a warehouse holds 999 pieces and the max orderable quantity is 50, the API will return 50 as the available stock. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Theres the link for product input, but this setting can be changed globally in SiteSettings (and adjusted in linked variant input). |
||
|
||
### Click-and-collect warehouses | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permissions part is a bit unclear for me: