feat: add rule matching secrets used without environment#10
Merged
NyanKiyoshi merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
NyanKiyoshi
added a commit
that referenced
this pull request
Mar 4, 2026
Needed by #10, latest version fixes a bug with the `--validate` command (which causes the CI to fail). Version is also ancient thus needs upgrading
NyanKiyoshi
force-pushed
the
feat/yaml/gha/add-secrets-without-environment
branch
from
cd9feed to
fb68cdc
Compare
IKarbowiak
previously approved these changes
Mar 5, 2026
NyanKiyoshi
added a commit
that referenced
this pull request
Mar 5, 2026
Needed by #10, latest version fixes a bug with the `--validate` command (which causes the CI to fail). Version is also ancient thus needs upgrading
This adds a Semgrep rule that ensures all `${{ secrets.XXX }}` interpolations use the `environment` keyword to ensure blast radius is limited and to ensure protection rules are followed (branch protections, tag protections, …).
NyanKiyoshi
force-pushed
the
feat/yaml/gha/add-secrets-without-environment
branch
from
fb68cdc to
2f61598
Compare
Member
Author
|
(Branch was rebased cleaned) |
IKarbowiak
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Semgrep rule that ensures all
${{ secrets.XXX }}interpolations use theenvironmentkeyword to ensure blast radius is limited and to ensure protection rules are followed (branch protections, tag protections, …).