fix: error when using default action config#9
Merged
NyanKiyoshi merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
This fixes a crash when using the default config from our repository, the workflow would error-out with the following: ``` $ docker-here returntocorp/semgrep@sha256:396f4ad7a655289e764ab2f92733e6195c166ff2f042e0d40505a5850432b9ac semgrep --metrics=off --config=./ ./ semgrep error: Invalid rule schema --> .github/dependabot.yaml:1 1 | version: 2 2 | 3 | updates: 4 | - package-ecosystem: "github-actions" 5 | directory: "/" 6 | schedule: 7 | interval: "monthly" 8 | cooldown: 9 | default-days: 21 # 3 weeks One of these properties is missing: 'rules' [ERROR] invalid configuration file found (1 configs were invalid) ``` This is due to Semgrep selecting all YAML files, including the ones under `.github/`. In the past, Semgrep was excluding hidden folders which isn't the case anymore. Results after the changes: ``` $ docker-here returntocorp/semgrep@sha256:396f4ad7a655289e764ab2f92733e6195c166ff2f042e0d40505a5850432b9ac semgrep --metrics=off --config=./yaml --config=./typescript ./ ┌─────────────┐ │ Scan Status │ └─────────────┘ Scanning 13 files (only git-tracked) with 2 Code rules: CODE RULES Scanning 6 files. SUPPLY CHAIN RULES No rules to run. PROGRESS ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 ┌──────────────┐ │ Scan Summary │ └──────────────┘ Some files were skipped or only partially analyzed. Scan was limited to files tracked by git. Scan skipped: 2 files matching .semgrepignore patterns For a full list of skipped files, run semgrep with the --verbose flag. Ran 1 rule on 6 files: 0 findings. ```
IKarbowiak
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash when using the default config from our repository, the workflow would error-out with the following:
This is due to Semgrep selecting all YAML files, including the ones under
.github/. In the past, Semgrep was excluding hidden folders which isn't the case anymore.Results after the changes: