Skip to content

Fix #8632 - API V8 /meta/fields/{moduleName} endpoint output without field labels #10648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

ssamko0911
Copy link

Description

See the issue:
#8632

Motivation and Context

'Include field labels into field description'

  1. Without field labels, API consumers must manually map field names to their corresponding labels, making development more difficult.
  2. There's a slight typo, which makes additional information not available:
  • there is no such key as 'comments'
    image

image

Updated:
image

Thanks!

How To Test This

See the issue:
#8632

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@mattlorimer mattlorimer added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: API Issues & PRs related to all things regarding the API PR 1-3 Complexity Score given to PRs once assessed labels Mar 25, 2025
Copy link
Member

@mattlorimer mattlorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mattlorimer mattlorimer added the Status: Passed Code Review Mark issue has passed code review reviewed label Mar 25, 2025
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User can see Labels now when calling metadata API

One thing to note though, is that the labels will be shown in English, unlike other metadata calls, as these are the ones on the default vardefs.

Assuming this is expected, LGTM!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Issues & PRs related to all things regarding the API PR 1-3 Complexity Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants