Skip to content

Fixed #8279 - ProjectTask - no Task ID #8342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixed #8279 - ProjectTask - no Task ID #8342

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ec50f3
Merge pull request #13 from salesagility/hotfix-7.10.x
604media Nov 21, 2019
ee46d1b
Merge pull request #14 from salesagility/hotfix-7.10.x
604media Nov 26, 2019
204c3d9
Merge pull request #15 from salesagility/hotfix-7.10.x
604media Nov 29, 2019
ba50307
Fixed #8279 - ProjectTask - no Task ID
processflowca Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/ProjectTask/ProjectTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public function save($check_notify = false)
{
//Bug 46012. When saving new Project Tasks instance in a workflow, make sure we set a project_task_id value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this comment can be removed now, it's not really necessary and no longer makes sense.

//associated with the Project if there is no project_task_id specified.
if ($this->in_workflow && empty($this->id) && empty($this->project_task_id) && !empty($this->project_id)) {
if (empty($this->id) && empty($this->project_task_id) && !empty($this->project_id)) {
$this->project_task_id = $this->getNumberOfTasksInProject($this->project_id) + 1;
}

Expand Down