Fix messages #153
Draft
Fix messages #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenamverma
commented
May 8, 2025
| @@ -1,5 +1,6 @@ | |||
| import { findAttr, isAttributesEmpty } from "./utils/node"; | |||
| import metadata from '@salesforce-ux/sds-metadata'; | |||
| import { formatMessageWithSuggestions } from '../../../shared-utils/src'; | |||
There was a problem hiding this comment.
Should we use as a package or relative path?
There was a problem hiding this comment.
- Letz create package , but skipped from publishing
- move all rule message formatting related code into this
- update esling and stylelint plugins to use this package
- update esbuild of esling and stylelint plugins to bundle this package
Name of the package can be rule-meta
There was a problem hiding this comment.
Planning to hold this PR until we decide on the rule-meta end. I can create the function on top of that work. Don't want to merge two work items in this PR.
kenamverma
commented
May 8, 2025
| * @param suggestions Array of suggestion objects to include | ||
| * @returns Stringified JSON object containing message and suggestions | ||
| */ | ||
| export function formatMessageWithSuggestions(message: string, suggestions: string[]): string { |
There was a problem hiding this comment.
Created a function so that we can in case needed.
|
sf-nithappu
added
on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.