update to ICU 75 #64
Merged
update to ICU 75 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update TextDirection and PluralRules with latest information, especially -1 being "one" not "other" Use non-breaking space for "PM" Update 12hr am test to ignore es_AR, since checkAM fixes it
steventamm
commented
Feb 13, 2025
| <version>3.0.0-M8</version> | ||
| <configuration> | ||
| <!-- suppress all loggings for unit test --> | ||
| <argLine>@{argLine} -Djava.util.logging.config.file=src/test/resources/logging.properties</argLine> |
Contributor
Author
There was a problem hiding this comment.
Removes a warning when using GraalJS without GraalVM
steventamm
commented
Feb 13, 2025
| Date sampleDate = I18nDateUtil.parseTimestamp("2008-03-13 13:00:00"); | ||
| // In JDK 6, they fixed danish. | ||
| assertEquals("13.03.2008", BaseLocalizer.getLocaleDateFormat(new Locale("da"), tz).format(sampleDate)); | ||
| assertEquals("13.03.2008 13.00", BaseLocalizer.getLocaleDateTimeFormat(new Locale("da"), tz).format(sampleDate)); |
Contributor
Author
There was a problem hiding this comment.
Danish now has a comma with the time
steventamm
commented
Feb 13, 2025
|
|
||
| // Validate with US | ||
| assertEquals("3/13/2008", BaseLocalizer.getLocaleDateFormat(Locale.US, tz).format(sampleDate)); | ||
| assertEquals("3/13/2008, 1:00 PM", BaseLocalizer.getLocaleDateTimeFormat(Locale.US, tz).format(sampleDate)); |
Contributor
Author
There was a problem hiding this comment.
The format switched from space (U+20 to U+202F) for the non-breaking space
Contributor
Author
There was a problem hiding this comment.
This might be undesirable...
steventamm
commented
Feb 13, 2025
| // H for 24-hours time format, h for 12-hours format. | ||
| if ((p.indexOf('a') == -1) && (p.indexOf('k') == -1) && (p.indexOf('B') == -1)) { | ||
| assertNotEquals("Locale:" + u_loc.getName() + " has incorrect time format " + p, -1, p.indexOf('H')); | ||
| // Locale has 12 hour time, but no am/pm marker. |
Contributor
Author
There was a problem hiding this comment.
Switched to include all the bad locales.
steventamm
commented
Feb 13, 2025
| public void testICUCurrencyCode2JDK() { | ||
| List<String> res = new ArrayList<String>(); | ||
| ImmutableSet<String> exceptions = ImmutableSet.of("MRU", "VES", "STN"); | ||
| ImmutableSet<String> exceptions = ImmutableSet.of("MRU", "VES", "STN", "XCG", "ZWG"); |
Contributor
Author
There was a problem hiding this comment.
Currency difference between JDK 22 and ICU for new currencies in 2025
Contributor
Author
|
@yoikawa FYI |
yoikawa
reviewed
Feb 18, 2025
Contributor
|
Thanks @steventamm! Do you need this fix as patch release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TextDirection and PluralRules with latest information, especially -1 being "one" not "other"
Use non-breaking space for "PM"
Update 12hr am test to ignore es_AR, since checkAM fixes it