fixed IllegalArgumentException #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoikawa
commented
Jul 14, 2025
| // fix if neither 'H' or 'k' (24-hour) does not present, and if 'a' or 'B' | ||
| // (AM/PM notation) doesn't exist. ICU version of SimpleDateFormat may return 'B' for zh-TW | ||
| if ((p.indexOf('H') == -1 && p.indexOf('k') == -1) && (p.indexOf('a') == -1 && p.indexOf('B') == -1)) { | ||
| df.applyPattern(p + " a"); |
Contributor
Author
There was a problem hiding this comment.
- add extra check for
'B' - no need to construct new
SimpleDateFormat, but just callapplyPattern(String)here.
ytanida
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IllegalArgumentis thrown fromBaseLocalizer.JdkFormatFixer.checkAMif all condition below are met:-Djava.locale.proviers=SPIoption (uses ICU over JDK)FormatFixer(default behavior)"zh-TW"ICU version of SimpleDateFormat.toPattern() returns
"y/M/d Bh:mm"where the'B'is not supported by JDK.The method did not check
'B'along with'a'as AM/PM notation and pass the pattern to JDK'snew SimpleDateFormatthat throws this exception.