add Basque language support #72
Conversation
| * @return a sample dictionary file containing the xml snippet inside the "names" tag | ||
| */ | ||
| public static String getSampleGrammarFile(@Nullable String grammar) { | ||
| public static String getSampleGrammarFile(String grammar) { |
There was a problem hiding this comment.
Is there a reason we're removing this? Does it have to do with the dependency/JDK version upgrades?
There was a problem hiding this comment.
Thanks for flagging this. It’s not tied to the JDK or dependency upgrades. I removed @Nullable to avoid signaling a nullness policy we haven’t standardized across the codebase. Today, nullness annotations leak in indirectly (e.g., the checkerframework via Guava), but we don’t consistently apply them nor run a nullness checker in CI.
To keep behavior unchanged—this method is used by tests—we still accept null and guard explicitly. I’d prefer to address nullness holistically in a follow-up: choose a single annotation library, enable the checker, and audit the public API surface. If you’d rather keep @Nullable here for interim clarity, I can revert in this PR and do the broader cleanup in a dedicated branch.
| <groupId>com.ibm.icu</groupId> | ||
| <artifactId>icu4j</artifactId> | ||
| <version>${icu4j.version}</version> | ||
| <version>75.1</version> |
There was a problem hiding this comment.
Can this be pulled into a property variable?
3 participants
Candidate for Release 1.3.0
Highlights
src/main/java/com/force/i18n/grammar/impl/BasqueDeclension.javafor details.Upgrade notes
References
BasqueDeclension.javaBasqueAdjectiveRefTag.java, related parser changesBasqueDeclensionTest,BasqueAdjectiveRefTagTest,BasqueCaseRenderingTest,BasqueDictionaryParsingTest