Basque: Expand declension test coverage and add safe fallback for dynamic noun indices #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthinkel
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Increase Basque declension test coverage and introduce a safer default when resolving out-of-range dynamic noun indices.
Changes:
Add additional combinations of declension tests.
When a dynamic noun index is out of range, fall back to index 0 instead of crashing or rendering a placeholder like "{0}".
Example:
Entities:
{Account, Contact}Token:
<entity entity="99"/><entity entity="0"/>and resolves to Account.Impact:
Behavior change only in out-of-range scenarios; normal cases are unaffected.
Rationale:
Provides predictable, non-crashing behavior and avoids bogus output in edge cases.