feat: explicitly import CJS bundles for LWC @W-21382713#404
Open
feat: explicitly import CJS bundles for LWC @W-21382713#404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LWC v8 is CJS by default (no
typein package.json andmainpoints todist/index.cjs.js). LWC v9 is ESM by default (type: moduleandmainpoints to ESMdist/index.js). For compatibility, LWC v9 also providesdist/index.cjs.In this PR, we change references to
@lwc/engine-dom(and friends) to@lwc/engine-dom/dist/index.cjs. Because of node's flexible module resolution algorithm, this resolves to the CJS bundle for both v8 and v9. No further code changes are required to support both v8 and v9. The downside of this approach, however, is that it takes an explicit dependency on the CJS bundle, effectively just kicking the can down the road for the CJS -> ESM switchover.