refactor(ssr): do not pass props/attrs to tmpl (#5095)

salesforce · Jan 6, 2025 · 0013158 · 0013158
1 parent abfe39f
commit 0013158
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/packages/@lwc/ssr-compiler/src/compile-js/generate-markup.ts b/packages/@lwc/ssr-compiler/src/compile-js/generate-markup.ts
@@ -64,11 +64,9 @@ const bGenerateMarkup = esTemplate`
         yield* __renderAttrs(instance, attrs, hostScopeToken, scopeToken);
         yield '>';
         yield* tmplFn(
-            props, 
-            attrs, 
             shadowSlottedContent,
-            lightSlottedContent, 
-            ${/*component class*/ 3}, 
+            lightSlottedContent,
+            ${/*component class*/ 3},
             instance
         );
         yield \`</\${tagName}>\`;

diff --git a/packages/@lwc/ssr-compiler/src/compile-template/index.ts b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
@@ -21,11 +21,9 @@ import type { CompilationMode } from '@lwc/shared';
 // TODO [#4663]: Render mode mismatch between template and compiler should throw.
 const bExportTemplate = esTemplate`
     export default async function* tmpl(
-            props, 
-            attrs, 
             shadowSlottedContent,
-            lightSlottedContent, 
-            Cmp, 
+            lightSlottedContent,
+            Cmp,
             instance
     ) {
         // Deliberately using let so we can mutate as many times as we want in the same scope.

diff --git a/packages/@lwc/ssr-runtime/src/render.ts b/packages/@lwc/ssr-runtime/src/render.ts
@@ -96,8 +96,6 @@ export function renderAttrsNoYield(
 }
 
 export function* fallbackTmpl(
-    _props: unknown,
-    _attrs: unknown,
     _shadowSlottedContent: unknown,
     _lightSlottedContent: unknown,
     Cmp: LightningElementConstructor,
@@ -110,8 +108,6 @@ export function* fallbackTmpl(
 
 export function fallbackTmplNoYield(
     emit: (segment: string) => void,
-    _props: unknown,
-    _attrs: unknown,
     _shadowSlottedContent: unknown,
     _lightSlottedContent: unknown,
     Cmp: LightningElementConstructor,