test(wtr): fix all broken tests! @W-19098252 (#5516)

* test(wtr): use async/await instead of promise chains

* Apply suggestion from @wjhsf

* test(wtr): fix test assertion

an error object is logged, not just a plain string

* test(wtr): remove unnecessary custom matcher

OOTB matcher with nearly identical name exists

* test(wtr): implement missing jasmine matcher

Author: wjhsf

packages/@lwc/integration-not-karma/configs/base.js

@@ -29,6 +29,7 @@ export default {
     // time out before they receive focus. But it also makes the full suite take 3x longer to run...
     // Potential workaround: https://github.com/modernweb-dev/web/issues/2588
     concurrency: 1,
+    browserLogs: false,
     nodeResolve: true,
     rootDir: join(import.meta.dirname, '..'),
     plugins: [

packages/@lwc/integration-not-karma/configs/integration.js

@@ -5,16 +5,7 @@ import testPlugin from './plugins/serve-integration.js';
 /** @type {import("@web/test-runner").TestRunnerConfig} */
 export default {
     ...baseConfig,
-    files: [
-        // FIXME: These tests are just symlinks to integration-karma for now so the git diff smaller
-        'test/**/*.spec.js',
-
-        // Logging mismatches
-        '!test/component/LightningElement.addEventListener/index.spec.js',
-
-        // Implement objectContaining / arrayWithExactContents
-        '!test/profiler/mutation-logging/index.spec.js',
-    ],
+    files: ['test/**/*.spec.js'],
     plugins: [
         ...baseConfig.plugins,
         importMapsPlugin({ inject: { importMap: { imports: { lwc: './mocks/lwc.js' } } } }),

packages/@lwc/integration-not-karma/configs/plugins/serve-integration.js

@@ -81,6 +81,7 @@ const transform = async (ctx) => {
         plugins: [customLwcRollupPlugin],
 
         external: [
+            '@vitest/expect',
             '@vitest/spy',
             'lwc',
             'wire-service',

packages/@lwc/integration-not-karma/helpers/matchers/jasmine.js

@@ -19,11 +19,6 @@ export const registerJasmineMatchers = (chai, utils) => {
             // eslint-disable-next-line @typescript-eslint/no-unused-expressions
             chai.expect(value).to.be.true;
         },
-        toHaveBeenCalledOnceWith(...args) {
-            const spy = utils.flag(this, 'object');
-            chai.expect(spy.calls).to.have.length(1);
-            chai.expect(spy.calls[0]).to.deep.equal(args);
-        },
     };
 
     for (const [name, impl] of Object.entries(matchers)) {

packages/@lwc/integration-not-karma/package.json

@@ -16,6 +16,7 @@
         "@lwc/synthetic-shadow": "8.22.3",
         "@types/chai": "^5.2.2",
         "@types/jasmine": "^5.1.9",
+        "@vitest/expect": "^3.2.4",
         "@vitest/spy": "^3.2.4",
         "@web/dev-server-import-maps": "^0.2.1",
         "@web/dev-server-rollup": "^0.6.4",

packages/@lwc/integration-not-karma/test/component/LightningElement.addEventListener/index.spec.js

@@ -55,8 +55,13 @@ describe('event handler is not a function', () => {
         if (process.env.NODE_ENV === 'production') {
             expect(consoleSpy).not.toHaveBeenCalled();
         } else {
+            expect(consoleSpy).toHaveBeenCalledExactlyOnceWith(expect.any(Error));
             expect(consoleSpy).toHaveBeenCalledExactlyOnceWith(
-                expect.stringContaining('Invalid second argument for this.addEventListener()')
+                expect.objectContaining({
+                    message: expect.stringContaining(
+                        'Invalid second argument for this.addEventListener()'
+                    ),
+                })
             );
         }
     });

packages/@lwc/integration-not-karma/test/profiler/mutation-logging/index.spec.js

@@ -2,28 +2,40 @@ import { createElement } from 'lwc';
 import Parent from 'x/parent';
 import Child from 'x/child';
 import GetterThrows from 'x/getterThrows';
-import { jasmine, jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
+import { ArrayContaining } from '@vitest/expect';
+import { spyOn } from '@vitest/spy';
+
+class ArrayWithExactContents extends ArrayContaining {
+    asymmetricMatch(other) {
+        return (
+            super.asymmetricMatch(other) &&
+            (this.inverse
+                ? this.sample.length !== other.length
+                : this.sample.length === other.length)
+        );
+    }
+}
 
-const arr = jasmine.arrayWithExactContents;
-// `jasmine.objectContaining` is long, but the method can't be detached/aliased, ergo wrapper
-const obj = (val) => jasmine.objectContaining(val);
+const arr = (val) => new ArrayWithExactContents(val);
+const obj = (val) => expect.objectContaining(val);
 
 let entries = [];
 
-beforeEach(() => {
-    const perfMeasure = performance.measure.bind(performance);
-
-    // We could use PerformanceObserver for this, but it's awkward and unreliable for unit testing
-    // See: https://github.com/salesforce/lwc/issues/4600
-    spyOn(performance, 'measure').and.callFake((...args) => {
-        const entry = perfMeasure(...args);
+beforeAll(() => {
+    const realMeasure = performance.measure.bind(performance);
+    spyOn(performance, 'measure').mockImplementation((...args) => {
+        const entry = realMeasure(...args);
         if (['lwc-render', 'lwc-rerender'].includes(entry.name)) {
             entries.push(entry);
         }
         return entry;
     });
 });
 
+afterAll(() => {
+    performance.measure.mockRestore();
+});
+
 afterEach(() => {
     entries = [];
 });

packages/@lwc/integration-not-karma/test/rendering/iframe/index.spec.js

@@ -14,5 +14,5 @@ it('renders iframes correctly - W-17015807', async () => {
 
     await Promise.resolve();
 
-    expect(spy).toHaveBeenCalledOnceWith('src', 'about:blank');
+    expect(spy).toHaveBeenCalledExactlyOnceWith('src', 'about:blank');
 });

yarn.lock

@@ -3569,7 +3569,7 @@
     "@typescript-eslint/scope-manager" "^8.41.0"
     "@typescript-eslint/utils" "^8.24.1"
 
-"@vitest/expect@3.2.4":
+"@vitest/expect@3.2.4", "@vitest/expect@^3.2.4":
   version "3.2.4"
   resolved "https://registry.yarnpkg.com/@vitest/expect/-/expect-3.2.4.tgz#8362124cd811a5ee11c5768207b9df53d34f2433"
   integrity sha512-Io0yyORnB6sikFlt8QW5K7slY4OjqNX9jmJQ02QDda8lyM6B5oNgVWoSoKPac8/kgnCUzuHQKrSLtu/uOqqrig==