Merge branch 'master' into wjh/rewire

Author: wjhsf

packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts

@@ -11,6 +11,7 @@ import { rollup } from 'rollup';
 import lwcRollupPlugin from '@lwc/rollup-plugin';
 import { testFixtureDir, formatHTML } from '@lwc/test-utils-lwc-internals';
 import { setFeatureFlagForTest } from '../index';
+import type { FeatureFlagName } from '@lwc/features/dist/types';
 import type { RollupLwcOptions } from '@lwc/rollup-plugin';
 import type * as lwc from '../index';
 
@@ -128,16 +129,17 @@ function testFixtures(options?: RollupLwcOptions) {
             // the LightningElement. Therefor the compiled module should also be evaluated in the
             // same sandbox registry as the engine.
             const lwcEngineServer = await import('../index');
-            const module = (await import(compiledFixturePath)) as FixtureModule;
-
-            const features = module!.features ?? [];
-            features.forEach((flag) => {
-                lwcEngineServer!.setFeatureFlagForTest(flag, true);
-            });
 
             let result;
             let err;
+            let features: FeatureFlagName[] = [];
             try {
+                const module = (await import(compiledFixturePath)) as FixtureModule;
+
+                features = module!.features ?? [];
+                features.forEach((flag) => {
+                    lwcEngineServer!.setFeatureFlagForTest(flag, true);
+                });
                 result = formatHTML(
                     lwcEngineServer!.renderComponent(
                         module!.tagName,
@@ -146,10 +148,10 @@ function testFixtures(options?: RollupLwcOptions) {
                     )
                 );
             } catch (_err: any) {
-                if (_err.name === 'AssertionError') {
+                if (_err?.name === 'AssertionError') {
                     throw _err;
                 }
-                err = _err.message;
+                err = _err?.message || 'An empty error occurred?!';
             }
 
             features.forEach((flag) => {

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/error.txt

@@ -0,0 +1,14 @@
+<x-parent>
+  <template shadowrootmode="open">
+    <x-child>
+      <template shadowrootmode="open">
+        const setter getter api value
+      </template>
+    </x-child>
+    <x-child>
+      <template shadowrootmode="open">
+        setter getter api value
+      </template>
+    </x-child>
+  </template>
+</x-parent>

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/expected.html

@@ -0,0 +1,3 @@
+export const tagName = 'x-parent';
+export { default } from 'x/parent';
+export * from 'x/parent';

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/index.js

@@ -0,0 +1,3 @@
+<template>
+    {setterGetterApi}
+</template>

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/modules/x/child/child.html

@@ -0,0 +1,12 @@
+import { LightningElement, api } from 'lwc';
+
+export default class Child extends LightningElement {
+    set setterGetterApi(value) {
+        this._someApi = value;
+    }
+
+    @api
+    get setterGetterApi() {
+        return this._someApi;
+    }
+}

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/modules/x/child/child.js

@@ -0,0 +1,4 @@
+<template>
+    <x-child setter-getter-api="const setter getter api value"></x-child>
+    <x-child setter-getter-api={setterGetterApiValue}></x-child>
+</template>

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/modules/x/parent/parent.html

@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class Parent extends LightningElement {
+    setterGetterApiValue = 'setter getter api value';
+}

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/modules/x/parent/parent.js

@@ -0,0 +1 @@
+LWC1112: @api get setterGetterApi and @api set setterGetterApi detected in class declaration. Only one of the two needs to be decorated with @api.